Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runner is a little too enthusiastic to not re-run tests #7540

Closed
catamorphism opened this issue Jul 2, 2013 · 6 comments
Closed

Test runner is a little too enthusiastic to not re-run tests #7540

catamorphism opened this issue Jul 2, 2013 · 6 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@catamorphism
Copy link
Contributor

For example, I do:

make check-stage2-rustpkg TESTNAME=first_test

Then when I do:

make check-stage2-rustpkg TESTNAME=second_test

make reports "Nothing to be done" because I guess running the first test touched some file somewhere that tells the build system "all the tests have up-to-date results". But really, only one test has up-to-date results. I work around this by touching a source file, but that results in recompilation, which is annoying.

@brson
Copy link
Contributor

brson commented Jul 10, 2013

The situation isn't ideal. rm tmp/*ok will reset the test state so the tests rerun though.

@thestinger
Copy link
Contributor

Still an issue.

@huonw
Copy link
Member

huonw commented Jan 19, 2014

Still an issue; I guess this could be solved by the extra::test runner recording which tests it has run, but then it becomes stateful, which is unfortunate :( (and this would still require integration into the makefiles).

@steveklabnik
Copy link
Member

Triage: still an issue.

@rasendubi
Copy link
Contributor

Still an issue

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 29, 2017

Closing. With rustbuild, it seems this issue is fixed.

touch src/librustdoc/lib.rs
./x.py test --stage 1 src/test/compile-fail --test-args xcrate-unit-struct
   => runs xcrate-unit-struct test
./x.py test --stage 1 src/test/compile-fail --test-args xcrate-private-by-
   => runs xcrate-private-by-default test
./x.py test --stage 1 src/test/compile-fail
   => ignores the two already-run tests (private-by-default and unit-struct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

7 participants