Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP standard library no longer builds #79203

Closed
jdm opened this issue Nov 19, 2020 · 4 comments · Fixed by #79205
Closed

UWP standard library no longer builds #79203

jdm opened this issue Nov 19, 2020 · 4 comments · Fixed by #79205
Assignees
Labels
O-windows-msvc Toolchain: MSVC, Operating system: Windows P-medium Medium priority regression-untriaged Untriaged performance or correctness regression.

Comments

@jdm
Copy link
Contributor

jdm commented Nov 19, 2020

Code

Running cargo build --target x86_64-uwp-windows-msvc -Z build-std yields:

error[E0432]: unresolved import `SetThreadStackGuarantee`
    --> /home/travis/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/windows/c.rs:1038:12
     |
1038 |     pub fn SetThreadStackGuarantee(_size: *mut c_ulong) -> BOOL {
     |            ^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared type `SetThreadStackGuarantee`
error: aborting due to previous error
error: could not compile `std`

Version it worked on

This works in July 27 rustc nightly.

Version with regression

It's broken in the Oct 6 rustc nightly, but possibly earlier.

@jdm jdm added O-windows-msvc Toolchain: MSVC, Operating system: Windows E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc regression-untriaged Untriaged performance or correctness regression. labels Nov 19, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 19, 2020
@jdm
Copy link
Contributor Author

jdm commented Nov 19, 2020

It looks like this code is responsible; presumably the compat_fn! macro doesn't handle the attribute correctly.

@jdm
Copy link
Contributor Author

jdm commented Nov 19, 2020

I suspect 8b2bdfd.

@jdm
Copy link
Contributor Author

jdm commented Nov 19, 2020

Verified that the 9/30 nightly works.

@jdm jdm self-assigned this Nov 19, 2020
@camelid camelid added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Nov 19, 2020
@camelid
Copy link
Member

camelid commented Nov 19, 2020

Assigning P-medium and removing I-prioritize as discussed in the prioritization working group.

@m-ou-se m-ou-se removed the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Nov 20, 2020
@bors bors closed this as completed in c9c57fa Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows-msvc Toolchain: MSVC, Operating system: Windows P-medium Medium priority regression-untriaged Untriaged performance or correctness regression.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants