Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for extra unix ExitStatusExt methods #80695

Closed
5 tasks done
ijackson opened this issue Jan 4, 2021 · 1 comment
Closed
5 tasks done

Tracking Issue for extra unix ExitStatusExt methods #80695

ijackson opened this issue Jan 4, 2021 · 1 comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ijackson
Copy link
Contributor

ijackson commented Jan 4, 2021

Feature gate: #![feature(unix_process_wait_more)]

This is a tracking issue for a collection of logically necessary but previously missing methods on ExitStatusExt, the Unix-specific extension trait for ExitStatus.

Public API

// std::src::sys::unix::ext::process

pub trait ExitStatusExt : private::Sealed {
    // this feature gate adds these methods:
    fn core_dumped(&self) -> bool; // WCOREDUMP
    fn stopped_signal(&self) -> Option<i32>; // WIFSTOPPED? WSTOPSIG
    fn continued(&self) -> bool; // WIFCONTINUED
    fn into_raw(self) -> i32;
}

Steps / History

Unresolved Questions

  • None; other than the breakage risk due to sealing this trait. the trait has been sealed for some time now.
@ijackson ijackson added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 4, 2021
@m-ou-se m-ou-se added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jan 6, 2021
@ijackson
Copy link
Contributor Author

The situation with Fuchsia has been discussed in #58590, where it seems to have been agreed that Fuchsia ought not to be treated as Unix. The current situation, with the stub impls, is considered fine for now, apparently. So I have ticked that box in the checklist.

I will propose an MR to stabilise this.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 22, 2021
…aahc

Stabilise unix_process_wait_more, extra ExitStatusExt methods

This stabilises the feature `unix_process_wait_more`.  Tracking issue rust-lang#80695, FCP needed.

This was implemented in rust-lang#79982 and merged in January.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 22, 2021
…aahc

Stabilise unix_process_wait_more, extra ExitStatusExt methods

This stabilises the feature `unix_process_wait_more`.  Tracking issue rust-lang#80695, FCP needed.

This was implemented in rust-lang#79982 and merged in January.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 23, 2021
…aahc

Stabilise unix_process_wait_more, extra ExitStatusExt methods

This stabilises the feature `unix_process_wait_more`.  Tracking issue rust-lang#80695, FCP needed.

This was implemented in rust-lang#79982 and merged in January.
@dtolnay dtolnay closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants