Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression 1.50: Code breaks due to newly stabalized std lib methods Ord::clamp and bool::then #80950

Closed
rylev opened this issue Jan 12, 2021 · 3 comments
Closed

regression 1.50: Code breaks due to newly stabalized std lib methods Ord::clamp and bool::then #80950

rylev opened this issue Jan 12, 2021 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.50.0

Comments

@rylev
Copy link
Member

rylev commented Jan 12, 2021

Two newly stabalized APIs (Ord::clamp and bool::then) caused regressions in crates due to their stabalization in the latest crater run. In total 4 crates were impacted by this.

This is likely to be closed with wont-fix, but I wanted to ensure it was noted somewhere.

@rustbot modify labels: +regression-from-stable-to-beta
@rustbot rustbot added regression-from-stable-to-beta Performance or correctness regression from stable to beta. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jan 12, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 13, 2021
@rylev rylev mentioned this issue Jan 14, 2021
Closed
@apiraino
Copy link
Contributor

Issue has been mentioned and noted in the latest crater run, so it will tracked there.

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 14, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.50.0 milestone Jan 14, 2021
@scottmcm
Copy link
Member

clamp is almost certainly wont-fix as being expected -- Ord::clamp was backed out back in 2017 for breakage, so it finally stabilizing now seems like acceptance of this (allowed) breakage.

@Mark-Simulacrum
Copy link
Member

Closing as expected and acceptable breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

No branches or pull requests
5 participants
@rylev @Mark-Simulacrum @apiraino @scottmcm @rustbot