Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #[stable] versions in CI #81308

Open
camelid opened this issue Jan 23, 2021 · 3 comments
Open

Test #[stable] versions in CI #81308

camelid opened this issue Jan 23, 2021 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jan 23, 2021 •
edited
Loading

Maybe this is an argument for testing since = in CI, I've seen people get it wrong by accident a lot.

Originally posted by @jyn514 in rust-lang/rustc-dev-guide#1036 (comment)

tidy is probably the right place to do it.
@camelid camelid added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jan 23, 2021
@camelid camelid mentioned this issue Jan 23, 2021
Merged
@jyn514
Copy link
Member

jyn514 commented Jan 24, 2021

Note that this should only test #[stable] attributes that are newly added, it makes total sense for old attributes to say an old version.

@jyn514
Copy link
Member

jyn514 commented Jan 24, 2021

And unstable doesn't have an attached version, so it doesn't need to be tested.

@jyn514 jyn514 changed the title Test #[stable] and #[unstable] versions in CI Test #[stable] versions in CI Jan 24, 2021
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 24, 2021
@camelid
Copy link
Member Author

camelid commented Jan 24, 2021

And unstable doesn't have an attached version, so it doesn't need to be tested.

I think I confused #[unstable] with language-level feature flags, which do have a version :)

@jyn514 jyn514 added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyn514 @camelid