Document how to stabilize a library feature #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
waiting-on-review
camelid
reviewed
Jan 23, 2021
m-ou-se
approved these changes
Jan 23, 2021
|
Even though we have an empty std dev guide where we should put this, I'd still be inclined to merge this here and we can look at migrating content around once the std dev guide actually has a home for it. |
camelid
reviewed
Jan 24, 2021
camelid
reviewed
Jan 24, 2021
Note that features can't be stabilized until they go through FCP and that FCP happens on the tracking issue, not the PR.
By default `**` behaves the same as two `*` side by side, i.e. it only globs file paths, not directories. `shopt -s globstar` needs to be set for it to mean a directory. I didn't notice this before now because `globstar` is set by default in interactive mode, but not otherwise.
|
@m-ou-se does this look good to you? |
m-ou-se
approved these changes
Feb 1, 2021
|
Thanks. @camelid @LeSeulArtichaut could one of you approve so I can merge? |
igaray
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #932.
r? @m-ou-se