Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid rendering for function parameters using destructuring #83852

Closed
GuillaumeGomez opened this issue Apr 4, 2021 · 3 comments · Fixed by #83863
Closed

Invalid rendering for function parameters using destructuring #83852

GuillaumeGomez opened this issue Apr 4, 2021 · 3 comments · Fixed by #83863
Assignees
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 4, 2021

This code:

pub fn body_owner(&self, BodyId { hir_id }: BodyId) -> HirId {
   // ...
}

renders the same in rustdoc, whereas it should be rendered like this:

pub fn body_owner(&self, _: BodyId) -> HirId;
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 4, 2021
@eggyal
Copy link
Contributor

eggyal commented Apr 4, 2021

@rustbot claim cat

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2021

Error: Parsing assign command in comment failed: ...'tbot claim' | error: expected end of command at >| ' cat '...

Please let @rust-lang/release know if you're having trouble with this bot.

@eggyal
Copy link
Contributor

eggyal commented Apr 4, 2021

@rustbot claim

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 5, 2021
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? ``@GuillaumeGomez``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 5, 2021
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? `@GuillaumeGomez`
jyn514 pushed a commit to jyn514/rust that referenced this issue Apr 5, 2021
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? ```@GuillaumeGomez```
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 5, 2021
Render destructured struct function param names as underscore

Fixes rust-lang#83852

r? ````@GuillaumeGomez````
@bors bors closed this as completed in 82b2863 Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants