Pretty-printer is still adding extra whitespace in places

[brson]

Diffs from a recent reformat:

     item_obj(_obj, [ty_param], /* constructor id */node_id);
     item_res(_fn,
-              /* dtor */
+
+             /* dtor */
              node_id,
-              /* dtor id */
+
+             /* dtor id */
              [ty_param],

     noreturn; // functions with return type _|_ that always
               // raise an error or exit (i.e. never return to the caller)

+

     alt c {


+
       // One-byte tokens.
       '?' {
         rdr.bump();
@@ -400,6 +401,7 @@ fn next_token_inner(rdr: &reader) -> token::token {
       }


+
       // Multi-byte tokens.
       '=' {

[brson]

At least one of these is the same issue as #751

[catamorphism]

Reproduced with this test case:

type _obj = int;
type ty_param = int;
type node_id = int;
type _fn = int;

enum foo {
  item_obj(_obj, ~[ty_param], /* constructor id */node_id),
  item_res(_fn,
              /* dtor */
              node_id,
              /* dtor id */
              ~[ty_param]
           )
}

I suspect these are all the same issue as #751, as all of them involve extra blank lines getting added before comments.

[pnkfelix]

linking to the metabug #3195 so that this ticket gets an entry (with status) in its comments area.

[flaper87]

still reproducible. Triaged

[brson]

Nobody is ever going to fix the current pretty-printer. Closing.