Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#84767 #85453

Closed
rust-highfive opened this issue May 18, 2021 · 2 comments · Fixed by #85721
Closed

rls no longer builds after rust-lang/rust#84767 #85453

rust-highfive opened this issue May 18, 2021 · 2 comments · Fixed by #85721
Assignees
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #84767, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @scottmcm, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels May 18, 2021
@scottmcm
Copy link
Member

Sure, I can look at this one.

@scottmcm
Copy link
Member

@Xanewok Thanks for merging racer-rust/racer#1167!

If I'm reading things right, I think I need a new crater release of it so I can update https://github.com/rust-lang/rls/blob/master/Cargo.toml#L46 ? If so, can you please make one of those?

@Xanewok Xanewok mentioned this issue May 26, 2021
@bors bors closed this as completed in 9a700d2 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants