Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The reduce method should document the order of the closure arguments #88927

Closed
lefth opened this issue Sep 14, 2021 · 1 comment
Closed

The reduce method should document the order of the closure arguments #88927

lefth opened this issue Sep 14, 2021 · 1 comment
Labels
C-bug Category: This is a bug.

Comments

@lefth
Copy link
Contributor

lefth commented Sep 14, 2021

reduce takes a closure argument, but does not explain the order of its arguments. The type signature does not help clarify the order as it would for fold. Also note that fold and try_fold do document the closure.

See: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.reduce
@lefth lefth added the C-bug Category: This is a bug. label Sep 14, 2021
@lefth lefth mentioned this issue Sep 14, 2021
Merged
Manishearth pushed a commit to Manishearth/rust that referenced this issue Sep 16, 2021
@lefth
Document the closure arguments for reduce.
6b7f916 
Fixes issue rust-lang#88927.
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 16, 2021
@Manishearth
Rollup merge of rust-lang#88928 - lefth:master, r=Mark-Simulacrum
ce9af0e 
Document the closure arguments for `reduce`.

See issue rust-lang#88927.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 16, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88928 - lefth:master, r=Mark-Simulacrum
757b316 
Document the closure arguments for `reduce`.

See issue rust-lang#88927.
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 16, 2021
@Manishearth
Rollup merge of rust-lang#88928 - lefth:master, r=Mark-Simulacrum
5b6285e 
Document the closure arguments for `reduce`.

See issue rust-lang#88927.
@Dylan-DPC
Copy link
Member

This has been fixed by #88928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lefth @Dylan-DPC