New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure that methods and impl blocks are rendered as expected for `reference` primitive. #90775

Closed

GuillaumeGomez opened this issue Nov 10, 2021 · 0 comments · Fixed by #90946

Assignees

Labels

A-testsuite T-rustdoc

Member

GuillaumeGomez commented Nov 10, 2021

As discussed in #90726.

GuillaumeGomez added the T-rustdoc label

GuillaumeGomez self-assigned this

GuillaumeGomez mentioned this issue

Remove weird edge case for "Type::inner_def_id" #90726

Closed

camelid added the A-testsuite label

GuillaumeGomez mentioned this issue

Ignore references in "Type::inner_def_id" #90946

Merged

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue


          Rollup merge of rust-lang#90946 - GuillaumeGomez:def-id-remove-weird-…

fcc90f2

…case, r=Manishearth

Ignore `reference`s in "Type::inner_def_id"

Fixes rust-lang#90775.

Reopening of rust-lang#90726.

As discussed on [zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rendering.20for.20reference.20primitive.20doc.20page), the reference page shouldn't list these implementations (since they are listed on the types and on the traits in any case). And more generally, you don't implement something on a reference but on something behind a reference. I think it's the important point.

So currently it looks like this:

![Screenshot from 2021-11-16 10-20-41](https://user-images.githubusercontent.com/3050060/141957799-57aeadc5-41f8-45f6-a4a5-33b1eca6a500.png)

With this PR, only the implementations over generics behind a reference are kept.

You can test it [here](https://rustdoc.crud.net/imperio/def-id-remove-weird-case/std/primitive.reference.html).

cc `@camelid`

bors closed this as completed in

775e969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment