rpath = false breaks run-make-fulldeps tests
#90921
Assignees
Labels
A-linkage
Area: linking into static, shared libraries and binaries
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
|
Do you happen to have any I can't reproduce this with the given command. Does it happen even after an |
|
There is a changelog-seen = 2
[llvm]
ccache = true
link-shared = true
[build]
build = 'x86_64-unknown-linux-gnu'
host = ['x86_64-unknown-linux-gnu']
target = ['x86_64-unknown-linux-gnu']
cargo = '/usr/bin/cargo'
rustc = '/usr/bin/rustc'
docs = false
compiler-docs = false
vendor = true
extended = true
tools = ['cargo']
configure-args = ['--build=x86_64-unknown-linux-gnu', '--host=x86_64-unknown-linux-gnu', '--target=x86_64-unknown-linux-gnu', '--prefix=/usr', '--bindir=/usr/bin', '--sysconfdir=/etc', '--datadir=/usr/share', '--localstatedir=/var', '--mandir=/usr/share/man', '--infodir=/usr/share/info', '--set', 'rust.deny-warnings=false', '--enable-local-rust', '--libdir=/usr/lib', '--docdir=/usr/share/doc/packages/rust', '--llvm-root=/usr', '--enable-llvm-link-shared', '--disable-codegen-tests', '--enable-optimize', '--enable-ccache', '--disable-docs', '--disable-compiler-docs', '--enable-verbose-tests', '--disable-rpath', '--enable-vendor', '--enable-extended', '--tools=cargo', '--release-channel=stable']
[install]
prefix = '/usr'
sysconfdir = '/etc'
docdir = '/usr/share/doc/packages/rust'
bindir = '/usr/bin'
libdir = '/usr/lib'
mandir = '/usr/share/man'
datadir = '/usr/share'
[rust]
optimize = true
channel = 'stable'
rpath = false
verbose-tests = true
codegen-tests = false
deny-warnings = false
[target.x86_64-unknown-linux-gnu]
llvm-config = '/usr/bin/llvm-config'
[dist]Seems that is reproducible after a clean: Do you think that can be something in the config.toml? I can experiment dropping features from there. |
You are totally correct here. Is the config.toml and the |
|
Hmm, I wonder if #13983 is related. |
jyn514
added
A-linkage
jyn514
changed the title
rpath = false breaks run-make-fulldeps tests
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Mar 17, 2024
Rollup merge of rust-lang#122270 - onur-ozkan:fix-rmake-test-with-rpath-false, r=Mark-Simulacrum fix `long-linker-command-lines` failure caused by `rust.rpath=false` Fixes `long-linker-command-lines` test failure (which happens when `rust.rpath` is set to `false`) by adjusting `LD_LIBRARY_PATH`. Fixes rust-lang#90921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running the tests from run-make-fulldeps, I found this one falling
It is complaining that
librustc_driver-0cce5dc831adf0c6.so, and indeed this file is not in theLD_LIBRARY_PATHset in the second one found afterRUSTC=. A simplefindreveals that this file is present in/home/abuild/rpmbuild/BUILD/rustc-1.56.1-src/build/x86_64-unknown-linux-gnu/stage1/libthat is included in the firstLD_LIBRARY_PATH. The second one have/home/abuild/rpmbuild/BUILD/rustc-1.56.1-src/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib, that contains a differentlibrustc_driver-XXX.so, with a different hash (librustc_driver-80572f832f8b69a0.so)I am not sure if the bug is that the second
LD_LIBRARY_PATHis missing this directory, or we are calling the wrongrustcthat indeed requires thelibrustc_driverwith a different hash.The text was updated successfully, but these errors were encountered: