Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on mingw32: make check shows 1265 test failures #9102

Closed
glycerine opened this issue Sep 10, 2013 · 3 comments
Closed

on mingw32: make check shows 1265 test failures #9102

glycerine opened this issue Sep 10, 2013 · 3 comments

Comments

@glycerine
Copy link

rust version:

  1. win32 install: following https://github.com/mozilla/rust/wiki/Note-getting-started-developing-Rust for Windows 8
  2. installed mingw (32-bit), and prereqs.
  3. installed ftp://sourceware.org/pub/pthreads-win32/pthreads-w32-2-9-1-release.zip, as per updated https://github.com/mozilla/rust/wiki/Note-getting-started-developing-Rust when I ran into 'libpthreadGC2.dll not found problem'.
  4. make builds rust, but make check fails 1265 tests. Transcript below.

Am I not building right... maybe the pthreadGC2.dll was not compatible after all? Just reaching at straws here.

make check
cfg: build triple i686-pc-mingw32
cfg: host triples i686-pc-mingw32
cfg: target triples i686-pc-mingw32
cfg: host for i686-pc-mingw32 is i386
cfg: os for i686-pc-mingw32 is pc-mingw32
cfg: using gcc
cfg: disabling valgrind due to its unreliability on this platform
/home/jaten/rust/mk/stage0.mk:7: warning: overriding commands for target `i686-pc-mingw32/stage0/bin/'
/home/jaten/rust/mk/stage0.mk:4: warning: ignoring old commands for target `i686-pc-mingw32/stage0/bin/'
cfg: no pandoc found, omitting docs
cfg: no node found, omitting docs
cfg: no llnextgen found, omitting grammar-verification
cfg: no pandoc found, omitting library doc build
cfg: including dist rules
cfg: including test rules
check: formatting
c:/MinGW/msys/1.0/home/jaten/rust/src/librustc/middle/trans/foreign.rs:98: NOTE These API constants ought to be more specific
c:/MinGW/msys/1.0/home/jaten/rust/src/libstd/c_str.rs:32: NOTE: this super::NullByteResolution should be NullByteResolution
c:/MinGW/msys/1.0/home/jaten/rust/src/libstd/rt/io/mod.rs:381: NOTE: this super::IoError should be IoError
c:/MinGW/msys/1.0/home/jaten/rust/src/libstd/rt/io/mod.rs:389: NOTE: this super::IoError should be IoError
c:/MinGW/msys/1.0/home/jaten/rust/src/libstd/rt/uv/file.rs:283: NOTE: need defs for S_**GRP|S_**OTH in libc:: ...
c:/MinGW/msys/1.0/home/jaten/rust/src/libsyntax/ext/expand.rs:1110: NOTE(acrichto): start removing this after the next snapshot
c:/MinGW/msys/1.0/home/jaten/rust/src/libsyntax/ext/expand.rs:1120: NOTE(acrichto): start removing this after the next snapshot
c:/MinGW/msys/1.0/home/jaten/rust/src/libsyntax/ext/expand.rs:1143: NOTE: use this after a snapshot lands to abstract the details
run rpass [i686-pc-mingw32]: i686-pc-mingw32/stage2/bin/compiletest.exe

running 1323 tests
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/alias-uninit-value.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/alignment-gep-tup-like-1.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/alignment-gep-tup-like-2.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893test [run-pass] run-pass/alloca-from-derived-tydesc.rs ... 
FAILED
test [run-pass] run-pass/anon-trait-static-method.rs ... FAILED
test [run-pass] run-pass/anon-extern-mod-cross-crate-2.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/anon-extern-mod.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/anon_trait_static_method_exe.rs ... FAILED
test [run-pass] run-pass/argument-passing.rs ... task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
FAILED
test [run-pass] run-pass/arith-0.rs ... FAILEDtask <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893

task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/arith-1.rs ... FAILED
test [run-pass] run-pass/arith-2.rs ... FAILED
test [run-pass] run-pass/artificial-block.rs ... task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
FAILED
test [run-pass] run-pass/arith-unsigned.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/assert-eq-macro-success.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/assign-assign.rs ... FAILED
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
task <unnamed> failed at 'assertion failed: end <= self.len()', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\vec.rs:893
test [run-pass] run-pass/attr-before-view-item.rs ... FAILED
...
too many failures to list
...

using metrics ratchet: tmp\check-stage2-T-i686-pc-mingw32-H-i686-pc-mingw32-rpass-metrics.json
result of ratchet: 0 matrics added, 0 removed, 0 improved, 0 regressed, 0 noise
updated ratchet file

failures:
    [run-pass] run-pass/alias-uninit-value.rs
    [run-pass] run-pass/alignment-gep-tup-like-1.rs
    [run-pass] run-pass/alignment-gep-tup-like-2.rs
    [run-pass] run-pass/alloca-from-derived-tydesc.rs
    [run-pass] run-pass/anon-extern-mod-cross-crate-2.rs
    [run-pass] run-pass/anon-extern-mod.rs
    [run-pass] run-pass/anon-trait-static-method.rs
    [run-pass] run-pass/anon_trait_static_method_exe.rs
    [run-pass] run-pass/argument-passing.rs
    [run-pass] run-pass/arith-0.rs
    [run-pass] run-pass/arith-1.rs
    [run-pass] run-pass/arith-2.rs

... 
too failures many to list, github says body is too long (maximum is 65535 characters)
...
    [run-pass] run-pass/yield2.rs

test result: FAILED. 0 passed; 1265 failed; 58 ignored; 0 measured

task <unnamed> failed at 'Some tests failed', C:\MinGW\msys\1.0\home\jaten\rust\src\compiletest\compiletest.rs:232
task <unnamed> failed at 'killed by linked failure', C:\MinGW\msys\1.0\home\jaten\rust\src\libstd\rt\kill.rs:627
make: *** [tmp/check-stage2-T-i686-pc-mingw32-H-i686-pc-mingw32-rpass.ok] Error 101
@klutzy
Copy link
Contributor

klutzy commented Sep 27, 2013

On win32 we only check make check-fast only. I've heard before that make check is broken on win32, but don't know current status.

@klutzy
Copy link
Contributor

klutzy commented Nov 20, 2013

This is fixed: #10452

@alexcrichton
Copy link
Member

hurray, thanks!

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 6, 2023
Added the `[unnecessary_box_returns]` lint

fixes rust-lang#5

I'm not confident in the name of this lint. Let me know if you can think of something better

---

changelog: New lint: ``[`unnecessary_box_returns`]``
[rust-lang#9102](rust-lang/rust-clippy#9102)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants