Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try_reserve_exact documentation says to "Prefer reserve" #91473

Closed
8573 opened this issue Dec 2, 2021 · 2 comments
Closed

try_reserve_exact documentation says to "Prefer reserve" #91473

8573 opened this issue Dec 2, 2021 · 2 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@8573
Copy link

8573 commented Dec 2, 2021

The documentation comments of the three try_reserve_exact methods stabilized today in 1.57.0 (in Vec, String, and VecDeque) all have the same note as the corresponding aborting method reserve_exact:

Prefer reserve if future insertions are expected.

For the fallible try_reserve_exact methods, should that say try_reserve rather than reserve?

@8573 8573 added the C-bug Category: This is a bug. label Dec 2, 2021
@inquisitivecrystal inquisitivecrystal added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 3, 2021
@AngelicosPhosphoros
Copy link
Contributor

This fixed on nightly.

@yaahc
Copy link
Member

yaahc commented Mar 1, 2022

fixed by #91547

@yaahc yaahc closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants