Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#91484 #91649

Closed
rust-highfive opened this issue Dec 8, 2021 · 3 comments · Fixed by #91666
Closed

miri no longer builds after rust-lang/rust#91484 #91649

rust-highfive opened this issue Dec 8, 2021 · 3 comments · Fixed by #91666
Assignees
@eddyb @RalfJung @oli-obk
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #91484, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @workingjubilee, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Dec 8, 2021
@workingjubilee
Copy link
Contributor

Ah, I see now. That PR removes splats (hopefully temporarily), and unfortunately, because of how natural it is, a few tests for Miri already use the splatting syntax. 🙃 Yes, I can clean this up.

@RalfJung
Copy link
Member

RalfJung commented Dec 8, 2021

Yeah I just tried vector $OP scalar and was happy to see it work. :)

@RalfJung RalfJung mentioned this issue Dec 8, 2021
Merged
@RalfJung
Copy link
Member

RalfJung commented Dec 8, 2021

Fix happening on the Miri side in rust-lang/miri#1934 (it was so easy I just quickly did it)

bors added a commit to rust-lang/miri that referenced this issue Dec 8, 2021
@bors
Auto merge of #1934 - RalfJung:rustup, r=RalfJung
dadcbeb 
rustup

Cc rust-lang/rust#91649
@RalfJung RalfJung mentioned this issue Dec 8, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#91666 - RalfJung:miri, r=RalfJung
8196a81 
update Miri

Fixes rust-lang#91649
r? `@ghost`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#91666 - RalfJung:miri, r=RalfJung
e63611a 
update Miri

Fixes rust-lang#91649
r? ``@ghost``
@bors bors closed this as completed in 229aa1b Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
5 participants
@eddyb @RalfJung @oli-obk @rust-highfive @workingjubilee