Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Describe item and member visibility in debugging information #9228

Closed
michaelwoerister opened this issue Sep 16, 2013 · 6 comments · Fixed by #115165
Closed

debuginfo: Describe item and member visibility in debugging information #9228

michaelwoerister opened this issue Sep 16, 2013 · 6 comments · Fixed by #115165
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

michaelwoerister commented Sep 16, 2013 •
edited by rustbot
Loading

This can be done using the flags parameter of various llvm::DIBuilder methods (e.g. createMemberType).
@flaper87
Copy link
Contributor

flaper87 commented Feb 8, 2014

Triage. This doesn't appear to have been implemented yet.

@michaelwoerister michaelwoerister added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 26, 2015
@michaelwoerister michaelwoerister mentioned this issue Apr 19, 2016
Closed
@steveklabnik
Copy link
Member

Triage: no idea. @michaelwoerister what's the status of this today?

@michaelwoerister
Copy link
Member Author

Still not implement, AFAIK.

@michaelwoerister michaelwoerister mentioned this issue Nov 18, 2016
Merged
@steveklabnik
Copy link
Member

Triage: I am not aware of any changes here.

@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 12, 2020
@rustbot rustbot self-assigned this Jul 26, 2020
@ernestask ernestask mentioned this issue Jul 26, 2020
Closed
@Alexendoo
Copy link
Member

Triage: Hi, are you still working on this issue @ernestask?

@rustbot rustbot removed their assignment Oct 10, 2020
@wesleywiser wesleywiser added the P-low Low priority label Aug 21, 2023
@wesleywiser
Copy link
Member

Visited during wg-debugging triage. Representing Rust semantics in debuginfo is useful but this kind of thing doesn't tend to affect the experience of debugging Rust code (this sort of thing is often used by tools other than the debugger which build on top of DWARF/CodeView). Marking as P-low.

@davidtwco davidtwco mentioned this issue Aug 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 26, 2023
@bors
Auto merge of rust-lang#115165 - davidtwco:issue-9228-describe-item-m…
fe9519c 
…ember-visibility, r=wesleywiser

codegen_llvm: set `DW_AT_accessibility`

Fixes rust-lang#9228.
Based on rust-lang#74778.

Sets the accessibility of types and fields in DWARF using `DW_AT_accessibility` attribute.

`DW_AT_accessibility` (public/protected/private) isn't exactly right for Rust,  but neither is `DW_AT_visibility` (local/exported/qualified), and there's no way to set `DW_AT_visbility` in LLVM's API. Debuggers will special-case the handling of these per-language anyway.

r? `@wesleywiser` (visited in wg-debugging triage)
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 25, 2023
@bors
Auto merge of rust-lang#115165 - davidtwco:issue-9228-describe-item-m…
4ab4817 
…ember-visibility, r=wesleywiser

codegen_llvm: set `DW_AT_accessibility`

Fixes rust-lang#9228.
Based on rust-lang#74778.

Sets the accessibility of types and fields in DWARF using `DW_AT_accessibility` attribute.

`DW_AT_accessibility` (public/protected/private) isn't exactly right for Rust,  but neither is `DW_AT_visibility` (local/exported/qualified), and there's no way to set `DW_AT_visbility` in LLVM's API. Debuggers will special-case the handling of these per-language anyway.

r? `@wesleywiser` (visited in wg-debugging triage)
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 15, 2023
@bors
Auto merge of rust-lang#115165 - davidtwco:issue-9228-describe-item-m…
47a262c 
…ember-visibility, r=wesleywiser

codegen_llvm: set `DW_AT_accessibility`

Fixes rust-lang#9228.
Based on rust-lang#74778.

Sets the accessibility of types and fields in DWARF using `DW_AT_accessibility` attribute.

`DW_AT_accessibility` (public/protected/private) isn't exactly right for Rust,  but neither is `DW_AT_visibility` (local/exported/qualified), and there's no way to set `DW_AT_visbility` in LLVM's API. Debuggers will special-case the handling of these per-language anyway.

r? `@wesleywiser` (visited in wg-debugging triage)
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 15, 2023
@bors
Auto merge of rust-lang#115165 - davidtwco:issue-9228-describe-item-m…
6af6885 
…ember-visibility, r=wesleywiser

codegen_llvm: set `DW_AT_accessibility`

Fixes rust-lang#9228.
Based on rust-lang#74778.

Sets the accessibility of types and fields in DWARF using `DW_AT_accessibility` attribute.

`DW_AT_accessibility` (public/protected/private) isn't exactly right for Rust,  but neither is `DW_AT_visibility` (local/exported/qualified), and there's no way to set `DW_AT_visbility` in LLVM's API. Debuggers will special-case the handling of these per-language anyway.

r? `@wesleywiser` (visited in wg-debugging triage)
@bors bors closed this as completed in 3f39cae Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen_llvm: set DW_AT_accessibility davidtwco/rust
7 participants
@flaper87 @steveklabnik @wesleywiser @jonas-schievink @michaelwoerister @Alexendoo @rustbot