Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustdoc search "crate filter" into the URL when it's being used #92621

Closed
GuillaumeGomez opened this issue Jan 6, 2022 · 0 comments · Fixed by #92735
Closed

Add rustdoc search "crate filter" into the URL when it's being used #92621

GuillaumeGomez opened this issue Jan 6, 2022 · 0 comments · Fixed by #92735
Assignees
@GuillaumeGomez
Labels
A-rustdoc-js Area: Rustdoc's front-end A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

Currently, only current search is put in the URL but not the crate filter if you used one, preventing you to share the exact search you just performed.

This idea was suggested by @jsha and I think it's a very good one so I'll implement it as soon as possible.
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-js Area: Rustdoc's front-end labels Jan 6, 2022
@GuillaumeGomez GuillaumeGomez self-assigned this Jan 6, 2022
@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 10, 2022
Merged
@bors bors closed this as completed in f2721fa Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-js Area: Rustdoc's front-end A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add crate filter parameter in URL GuillaumeGomez/rust
1 participant
@GuillaumeGomez