-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for #[deprecated_safe]
attribute
#94978
Labels
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
F-deprecated_safe
`#![feature(deprecated_safe)]`
S-tracking-impl-incomplete
Status: The implementation is incomplete.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
Comments
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Mar 17, 2022
…n-DPC Add deprecated_safe feature gate and attribute, cc rust-lang#94978
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Mar 18, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#91133 (Improve `unsafe` diagnostic) - rust-lang#93222 (Make ErrorReported impossible to construct outside `rustc_errors`) - rust-lang#93745 (Stabilize ADX target feature) - rust-lang#94309 ([generator_interior] Be more precise with scopes of borrowed places) - rust-lang#94698 (Remove redundant code from copy-suggestions) - rust-lang#94731 (Suggest adding `{ .. }` around a const function call with arguments) - rust-lang#94960 (Fix many spelling mistakes) - rust-lang#94982 (Add deprecated_safe feature gate and attribute, cc rust-lang#94978) - rust-lang#94997 (debuginfo: Fix ICE when generating name for type that produces a layout error.) - rust-lang#95000 (Fixed wrong type name in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Apr 11, 2022
@tmandry, maybe we should make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
F-deprecated_safe
`#![feature(deprecated_safe)]`
S-tracking-impl-incomplete
Status: The implementation is incomplete.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
This is a tracking issue for the lang-team MCP "Add #[deprecated_safe] attribute..." (rust-lang/lang-team#147).
The feature gate for the issue is
#![feature(deprecated_safe)]
.About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Public API
Apply
#[deprecated_safe]
to a pre-existing function or trait that is currently safe but needs to be marked unsafe, which is normally a breaking change. Marking the function or trait as unsafe and applying#[deprecated_safe]
will cause a "safeness deprecation" warning to be emitted anywhere that a compiler error would have been, maintaining backwards compatibility. While this is unsound, the intended use is to address a pre-existing unsoundness in a backwards compatible fashion using deprecations.Steps
Unresolved Questions
unsafe {}
block couldn't be added automatically. Is a non-autofixable edition change like that acceptable?Implementation history
The text was updated successfully, but these errors were encountered: