Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the rust tool #9775

Closed
brson opened this issue Oct 8, 2013 · 3 comments · Fixed by #9785
Closed

Remove the rust tool #9775

brson opened this issue Oct 8, 2013 · 3 comments · Fixed by #9785
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Oct 8, 2013

As discussed, it has a lot of problems, no owner, we can't commit to fixing it for Rust 1.0.
@brson
Copy link
Contributor Author

brson commented Oct 8, 2013

Nominating.

@ghost ghost assigned catamorphism Oct 8, 2013
@catamorphism
Copy link
Contributor

I'm going to do it.

@catamorphism catamorphism mentioned this issue Oct 9, 2013
Merged
@catamorphism
Copy link
Contributor

Done -- I'm just running a second round of tests after doing a clean build to make sure nothing is left behind, and then I'll submit a PR.

bors added a commit that referenced this issue Oct 11, 2013
@bors
auto merge of #9785 : catamorphism/rust/remove-convenience-tool, r=pc…
afa42a0 
…walton

r? @pcwalton Sadly, there's a lack of resources for maintaining the `rust` tool,
and we decided in the 2013-10-08 Rust team meeting that it's better
to remove it altogether than to leave it in a broken state.

This deletion is without prejudice. If a person or people appear who
would like to maintain the tool, we will probably be happy to
resurrect it!

Closes #9775
flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2023
@bors
Auto merge of rust-lang#10478 - Jarcho:block_eq, r=xFrednet
1e8d2c5 
`SpanlessEq` improvements

fixes rust-lang#9775

Also includes a simplification to `consts::constant`'s interface since I was already touching the code.

At the start of `eq_expr` the check:
```rust
if !self.inner.allow_side_effects && left.span.ctxt() != right.span.ctxt() {
    return false;
}
```
was removed. This was added in 49e2501 to handle `cfg` macros. This is better handled by the newly added `check_ctxt`.

changelog: [various lints]: Don't consider different `cfg!` expansions to be the same unless they are for the same config.
changelog: [various lints]: Don't consider the expansion of two different macros to be equal, even when they expand to the same token sequence.
changelog: [various lints]: Don't consider two blocks to be equal if they contain disabled code or empty macro expansions, unless those section contain the exact same token sequence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust / build: Remove the rust tool catamorphism/rust
2 participants
@brson @catamorphism