Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for feature(core_c_str) and feature(alloc_c_string) #98314

Closed
2 of 3 tasks
joshtriplett opened this issue Jun 20, 2022 · 7 comments
Closed
2 of 3 tasks
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@joshtriplett
Copy link
Member

joshtriplett commented Jun 20, 2022

Feature gate: #![feature(core_c_str)] and #![feature(alloc_c_string)]

This is a tracking issue for the availability of CStr in core and CString in alloc.

Public API

// core::ffi
pub struct CStr;
pub struct FromBytesWithNulError;

// alloc::ffi
pub struct CString;
pub struct NulError;
pub struct FromVecWithNulError;
pub struct IntoStringError;

Steps / History

@joshtriplett joshtriplett added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Jun 20, 2022
@joshtriplett
Copy link
Member Author

core::ffi::c_* appears to be on track to stabilize in 1.63.0. Shall we do the same for core::ffi::CStr and alloc::ffi::CString?

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jun 20, 2022

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 20, 2022
wwylele added a commit to wwylele/rust that referenced this issue Jun 27, 2022
(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jun 28, 2022
Remove unstable CStr/CString change from 1.62 release note

(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jun 28, 2022
Remove unstable CStr/CString change from 1.62 release note

(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 29, 2022
@rfcbot
Copy link

rfcbot commented Jun 29, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 29, 2022
@mbartlett21
Copy link
Contributor

If this ends up being done, will the type aliases in std be changed back to re-exports?

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jul 9, 2022
@rfcbot
Copy link

rfcbot commented Jul 9, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 9, 2022
@joshtriplett
Copy link
Member Author

@mbartlett21 I'd expect so.

@joshtriplett
Copy link
Member Author

This has been stabilized in #99277.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants