Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use llvm-libunwind="in-tree" for Fuchsia targets #100341

Merged
merged 1 commit into from Aug 13, 2022

Conversation

andrewpollack
Copy link
Member

With updates to Fuchsia CI's Zircon libraries #99833, we can introduce llvm-libunwind="in-tree" for Fuchsia targets. This PR restores functionality removed from #93604 (comment).

cc @tmandry @djkoloski

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 9, 2022
@rust-highfive
Copy link
Collaborator

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@tmandry
Copy link
Member

tmandry commented Aug 9, 2022

Can you also update the target docs so they don't say you need to override this anymore?

Removing libunwind from Fuchsia target docs
@andrewpollack
Copy link
Member Author

Can you also update the target docs so they don't say you need to override this anymore?

Good call -- done!

@tmandry
Copy link
Member

tmandry commented Aug 9, 2022

The bootstrap changes were already approved in #93604 (comment).

@bors r+ rollup=never (broke last time)

@bors
Copy link
Contributor

bors commented Aug 9, 2022

📌 Commit 29238f4 has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
@bors
Copy link
Contributor

bors commented Aug 12, 2022

⌛ Testing commit 29238f4 with merge 24041dbeb7a469050367aa1d63309a708fc46af1...

@bors
Copy link
Contributor

bors commented Aug 13, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 13, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@bors
Copy link
Contributor

bors commented Aug 13, 2022

⌛ Testing commit 29238f4 with merge e8dc8bc...

@bors
Copy link
Contributor

bors commented Aug 13, 2022

☀️ Test successful - checks-actions
Approved by: tmandry
Pushing e8dc8bc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2022
@bors bors merged commit e8dc8bc into rust-lang:master Aug 13, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 13, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e8dc8bc): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: ✅ relevant improvement found
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% -0.2% 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: ✅ relevant improvement found
mean1 max count2
Regressions ❌
(primary)
1.7% 2.3% 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.9% -2.9% 1
Improvements ✅
(secondary)
-3.6% -3.6% 1
All ❌✅ (primary) 0.5% -2.9% 4

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)
3.1% 3.9% 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.0% -3.0% 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% 3.9% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@tmandry tmandry added the O-fuchsia Operating system: Fuchsia label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants