Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate symbol_mangling module to new diagnostics structs #100831

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Migrate symbol_mangling module to new diagnostics structs #100831

merged 6 commits into from
Aug 31, 2022

Commits on Aug 30, 2022

  1. ADD - InvalidSymbolName to migrate symbol-name({}) error to new diagn… 

    …ostics infraestructure

ADD - dependencies needed to port a module to new Diagnostics infra (rustc_macros, rustc_errors, errors file, and fluent file)
    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    86f8c4e View commit details
    Browse the repository at this point in the history

  2. ADD - migrate InvalidTraitItem and AltInvalidTraitItem errors 

    Thought of doing this by having a struct and an enum with Default and Alt cases, but not sure if we wanted to have the text in code instead of having “demangling()” and “demangling-alt()” in the ftl file.

Don’t like the current way of having structs representing the same-ish and using long names to distinguish their expectations, instead of putting this in an enum and handling the different cases inside the type.

I am fine with whichever option the team prefers; also understand having them as separate structs keeps it simple.
    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    359002b View commit details
    Browse the repository at this point in the history

  3. UPDATE - accept String instead of unused 'str

    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    bd83bbc View commit details
    Browse the repository at this point in the history

  4. ADD - migrate InvalidDefPath to new diagnostics infra

    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    8f5fada View commit details
    Browse the repository at this point in the history

  5. ADD - diagnostics lints to symbol_mangling module

    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    ef2f6ab View commit details
    Browse the repository at this point in the history

  6. UPDATE - to support diag introduced in PR rust-lang#100765

    @JhonnyBillM
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    3ee6946 View commit details
    Browse the repository at this point in the history