Remove Sync requirement from lint pass objects
#101156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
Does the parallel compiler build with this change? |
|
It builds locally. CI is also building the parallel compiler is it not? |
|
I don't think CI builds the parallel compiler, like it doesn't even build more than just the x86_64-unknown-linux-gnu compiler in stage2. But I did check that enabling the parallel compiler and building this branch works, so this is fine then. @bors r+ |
bors
added
S-waiting-on-bors
|
The failure in #101140 only happens when building the parallel compiler, so I had assumed that was what CI was doing. |
|
Guess it does then 👍 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 29, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#100898 (Do not report too many expr field candidates) - rust-lang#101056 (Add the syntax of references to their documentation summary.) - rust-lang#101106 (Rustdoc-Json: Retain Stripped Modules when they are imported, not when they have items) - rust-lang#101131 (CTFE: exposing pointers and calling extern fn is just impossible) - rust-lang#101141 (Simplify `get_trait_ref` fn used for `virtual_function_elimination`) - rust-lang#101146 (Various changes to logging of borrowck-related code) - rust-lang#101156 (Remove `Sync` requirement from lint pass objects) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking the clippy sync (#101140). One of the lint passes contains a
Cellin order to make lifetimes work. It could be worked around, but this is the easier change to make if there are no objections.Rational for removing the requirement
&mut selfarguments.Sendis enough to lint different passes in parallel.LintStoreremainsSyncwith this. The constructor functions it contains still maintain theirSyncrequirement.r? rust-lang/compiler