Rollup of 13 pull requests #101290
Closed
Rollup of 13 pull requests #101290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with `x.py` as changed in rust-lang#95671 Fixes rust-lang#100459
This is so you can check out an upstream commit in src/llvm-project and have everything just work.
Needed after changes in rust-lang#97513.
Use third person, as it is used for other std documentation.
This fixes rustdoc not showing the current version as stabilization version for recently stabilized lang features.
Walkthrough currently say: ``` rustup target add aarch_64-fuchsia ``` but should say ``` rustup target add aarch64-fuchsia ```
The impl-items list stopped being nested inside a docblock since c1b1d68
The filename differed from the link in SUMMARY.md, causing it to 404.
Add `special_module_name` lint Declaring `lib` as a module is one of the most common beginner mistakes when trying to setup a binary and library target in the same crate. `special_module_name` lints against it, as well as `mod main;` ``` warning: found module declaration for main.rs --> $DIR/special_module_name.rs:4:1 | LL | mod main; | ^^^^^^^^^ | = note: a binary crate cannot be used as library warning: found module declaration for lib.rs --> $DIR/special_module_name.rs:1:1 | LL | mod lib; | ^^^^^^^^ | = note: `#[warn(special_module_name)]` on by default = note: lib.rs is the root of this crate's library target = help: to refer to it from other targets, use the library's name as the path ``` Note that the help message is not the best in that it doesn't provide an example of an import path (`the_actual_crate_name::`), and doesn't check whether the current file is part of a library/binary target to provide more specific error messages. I'm not sure where this lint would have to be run to access that information.
…lacrum Use `getuid` to check instead of `USER` env var in rustbuild This makes it consistent with `x.py` as changed in rust-lang#95671 Fixes rust-lang#100459
…mulacrum bootstrap: Add llvm-has-rust-patches target option This is so you can check out an upstream commit in src/llvm-project and have everything just work. This simplifies the logic in `is_rust_llvm` a bit; it doesn't need to check for download-ci-llvm because we would have already errored if both that and llvm-config were specified on the host platform.
Make docs formulation more consistent for NonZero{int}
Use third person, as it is used for other `std` documentation.
… r=Mark-Simulacrum Also replace the version placeholder in rustc_attr Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder. Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188). cc rust-lang#100591 
…re-whitespace, r=notriddle Remove unneeded where whitespace It fixes these two bugs:   It's a relic from a very old time (this commit: rust-lang@bfd01b7). You can test the result [here](https://rustdoc.crud.net/imperio/remove-unneeded-where-whitespace/lib2/struct.WhereWhitespace.html). cc ````````@jsha```````` r? ````````@notriddle````````
Fix bad target name in Walkthrough Walkthrough currently say: ``` rustup target add aarch_64-fuchsia ``` but should say ``` rustup target add aarch64-fuchsia ```
…re-css, r=jsha rustdoc: remove unused `.docblock .impl-items` CSS The impl-items list stopped being nested inside a docblock since c1b1d68
… r=tmandry Fixes/adjustments to Fuchsia doc walkthrough Small fixes/adjustments missed during rust-lang#100927
…lett Update outdated comment about output capturing in print_to.
Fix filename of armv4t-none-eabi.md The filename differed from the link in SUMMARY.md, causing it to 404.
Fix typo in comment
…-when-closure-is-already-marked-as-move, r=oli-obk Do not suggest adding `move` to closure when `move` is already used Fixes rust-lang#101227
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=13 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 1454696 with merge ed38d37680cb01707b3a84bc642851ef7b7d58b4... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
special_module_namelint #94467 (Addspecial_module_namelint)getuidto check instead ofUSERenv var in rustbuild #100852 (Usegetuidto check instead ofUSERenv var in rustbuild).docblock .impl-itemsCSS #101254 (rustdoc: remove unused.docblock .impl-itemsCSS)moveto closure whenmoveis already used #101285 (Do not suggest addingmoveto closure whenmoveis already used)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup