Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

region_names.rs : diag-mig #101309

Closed
wants to merge 2 commits into from
Closed

region_names.rs : diag-mig #101309

wants to merge 2 commits into from

Conversation

AndyJado
Copy link
Contributor

@AndyJado AndyJado commented Sep 2, 2022

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco reviewed Sep 2, 2022
View reviewed changes
compiler/rustc_borrowck/src/session_diagnostics.rs Outdated
@@ -157,3 +157,55 @@ pub(crate) enum RequireStaticErr {
multi_span: MultiSpan,
},
}

#[derive(SessionSubdiagnostic)]
pub(crate) enum RegionNameLables<'a> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub(crate) enum RegionNameLables<'a> {
pub(crate) enum RegionNameLabels<'a> {

typo

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@AndyJado
Copy link
Contributor Author

AndyJado commented Sep 3, 2022

moved

@AndyJado AndyJado closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco left review comments

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndyJado @rust-log-analyzer @davidtwco @rust-highfive @rustbot