Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation for env::home_dir()'s broken behaviour #101648

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Better documentation for env::home_dir()'s broken behaviour #101648

merged 2 commits into from
Dec 12, 2022

Commits on Sep 10, 2022

  1. Better documentation for env::home_dir()'s broken behaviour 

    This improves the documentation to say *why* it was deprecated. The reason was because it reads `HOME` on Windows which is meaningless there. Note that the PR that deprecated it stated that returning an empty string if `HOME` is set to an empty string was a problem, however I can find no evidence that this is the case. `cd` handles it fine whereas if `HOME` is unset it gives an explicit `HOME not set` error.

* Original deprecation reason: https://internals.rust-lang.org/t/deprecate-or-break-fix-std-env-home-dir/7315
* Original deprecation PR: rust-lang#51656

See rust-lang#71684
    @Timmmm
    Timmmm committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    8d08983 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Reword "has no meaning" per suggestion 

    Co-authored-by: Josh Triplett <josh@joshtriplett.org>
    @Timmmm @joshtriplett
    Timmmm and joshtriplett committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8f0025e View commit details
    Browse the repository at this point in the history