Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow defaults on type GATs #101807

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

jackh726
Copy link
Member

Fixes #99205

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
@est31
Copy link
Member

est31 commented Sep 14, 2022

This will probably also need a beta backport for the soon to branch beta, right?

@rust-log-analyzer

This comment has been minimized.

@davidtwco
Copy link
Member

r? rust-lang/compiler

Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, then r=me

thanks 😅 ❤️

Comment on lines 1697 to 1698
"defaults for type parameters are only allowed in \
`struct`, `enum`, `type`, or `trait` definitions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put that string into a const?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it can be made translatable right away? E.g. like this: 7ef610c

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really short on time this week. I'd rather get this in now, because don't want to miss beta cutoff.

@lcnr
Copy link
Contributor

lcnr commented Sep 14, 2022

r? @lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned davidtwco Sep 14, 2022
@jackh726
Copy link
Member Author

@est31 should be fine, can get this in before branch

@rust-log-analyzer

This comment has been minimized.

@jackh726
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Sep 14, 2022

📌 Commit d657d1f has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#93628 (Stabilize `let else`)
 - rust-lang#98441 (Implement simd_as for pointers)
 - rust-lang#101790 (Do not suggest a placeholder to const and static without a type)
 - rust-lang#101807 (Disallow defaults on type GATs)
 - rust-lang#101915 (doc: fix redirected link in `/index.html`)
 - rust-lang#101931 (doc: Fix a typo in `Rc::make_mut` docstring)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7c55c99 into rust-lang:master Sep 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 17, 2022
@jackh726 jackh726 deleted the no-gat-defaults branch September 17, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaults on GATs emit an error but function correctlyish
8 participants