Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify PartialEq for Ordering #101810

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Constify PartialEq for Ordering #101810

merged 1 commit into from
Sep 15, 2022

Conversation

raldone01
Copy link
Contributor

Adds impl const PartialEq for Ordering {} to #92391.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 14, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
@raldone01 raldone01 changed the title Constify PartialEq for Ordering. Constify PartialEq for Ordering Sep 14, 2022
@raldone01
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 14, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented Sep 14, 2022

CC @rust-lang/wg-const-eval

@raldone01 raldone01 changed the title Constify PartialEq for Ordering Constify PartialEq for Ordering Sep 14, 2022
@fee1-dead
Copy link
Member

fee1-dead commented Sep 14, 2022 •
edited
Loading

Thank you for the contribution!

r? @fee1-dead

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 14, 2022

📌 Commit f4ff686 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022
@fee1-dead fee1-dead assigned fee1-dead and unassigned thomcc Sep 14, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2022
@bors
Auto merge of rust-lang#101838 - matthiaskrgr:rollup-d1nm6b3, r=matth…
0a27ac1 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100415 (Add BE8 support)
 - rust-lang#101559 (Adding "backtrace off" option for fuchsia targets)
 - rust-lang#101740 (Adding ignore-fuchsia arg to non-applicable compiler ui tests)
 - rust-lang#101778 (rustdoc: clean up DOM by removing `.dockblock-short p`)
 - rust-lang#101786 (Tidy will not check coding style in bootstrap/target)
 - rust-lang#101810 (Constify `PartialEq` for `Ordering`)
 - rust-lang#101812 (rustdoc: clean up CSS `#titles` using flexbox)
 - rust-lang#101820 (rustdoc: remove no-op rule `a { background: transparent }`)
 - rust-lang#101828 (Add test for rust-lang#101743)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b71b640 into rust-lang:master Sep 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 15, 2022
@raldone01 raldone01 mentioned this pull request Sep 15, 2022
Open
3 tasks
@onestacked onestacked deleted the feat/const_partial_eq_ordering branch September 24, 2022 20:30
@onestacked
Copy link
Contributor

@rustbot label +const-hack

@rustbot rustbot added the const-hack This PR introduced a hack to make things valid in `const fn`. label Oct 2, 2022
@raldone01 raldone01 restored the feat/const_partial_eq_ordering branch January 3, 2023 21:58
@onestacked onestacked deleted the feat/const_partial_eq_ordering branch January 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
const-hack This PR introduced a hack to make things valid in `const fn`. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@raldone01 @rustbot @rust-highfive @rust-log-analyzer @thomcc @fee1-dead @bors @onestacked