builtin_macros: Migrate diagnostic #101935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #100996) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
This was referenced Oct 6, 2022
|
Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the same identifier as in the fluent file. For example, |
davidtwco
reviewed
Nov 2, 2022
| #[primary_span] | ||
| #[label] | ||
| pub(crate) span: Span, | ||
| // FIXME: This should be a `tool_only_span_suggestion` |
There was a problem hiding this comment.
I think we've got support for this now after #103575.
| WrappingNumberInArray { span: Span, snippet: String }, | ||
| } | ||
|
|
||
| impl AddSubdiagnostic for Snippet { |
There was a problem hiding this comment.
I think that you can use the derive for this.
|
@wonchulee any updates on this? |
Hello, This is still a work in progress, and as I mentioned in #100717, I don't have enough time to finish it these days. If someone would like to take it on, that would be great. I'll try to keep going as long as I can until then. |
|
Hi @wonchulee, I'm going to close this since you're not sure when you'll have time to work on it. Thank you for the effort you've put in already, and feel free to pick up the work later if you have more time :) (although do be aware that #110092 migrated a lot of the diagnostics in the meantime, so it might make sense to pick a crate other than rustc_builtin_macros). |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 4, 2024
…, r=davidtwco
Migrate some rustc_builtin_macros to SessionDiagnostic
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.
This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using
r? <reviewer name>
-->
Part of rust-lang#100717.
pick up abandoned pr: rust-lang#101935
`@rustbot` label +A-translation
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2024
Rollup merge of rust-lang#126405 - He1pa:translate_builtin_macro_diag, r=davidtwco Migrate some rustc_builtin_macros to SessionDiagnostic <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> --> Part of rust-lang#100717. pick up abandoned pr: rust-lang#101935 `@rustbot` label +A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc_biltin_macroscrate's diagnostic to translatable diagnostic structs.