Rollup of 11 pull requests #102022
Merged
Rollup of 11 pull requests #102022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in 2a1bad7 to go with this module summary function: https://github.com/rust-lang/rust/blob/2a1bad70dd9bc99d8db54964108b42da8f4e9fbd/src/librustdoc/html/format.rs#L767-L780 The corresponding HTML was removed in 0a46933.
I ran git config --file .gitmodules --name-only --get-regexp path and added all submodules that were not already in the list to it.
Tone down explanation on RefCell::get_mut
The language around `RefCell::get_mut` is remarkably sketchy and especially to the novice seems to quite strongly discourage using the method ("be cautious", "Also, please be aware", "special circumstances", "usually not what you want"). It was added six years ago in rust-lang#40634 due to confusion about when to use `get_mut` and `borrow_mut`.
While its signature limits the use-cases for `get_mut`, there is no chance for a safety footgun, and readers can be made aware of `borrow_mut` more softly. I've also just sent a [PR](rust-lang/rust-clippy#9044) to lint situations where `get_mut` could be used to improve ergonomics and performance.
So this PR tones down the language around `get_mut` and also brings it more in line with [`std::sync::Mutex::get_mut()`](https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.get_mut).
Make `from_waker`, `waker` and `from_raw` unstably `const` Make - `Context::from_waker` - `Context::waker` - `Waker::from_raw` `const`. Also added a small test.
…, r=sanxiyn Remove an unused struct field `late_bound`
Add help for invalid inline argument Fixes rust-lang#101712 Removed 1 part of the test as its identical with another one. Do let me know if this is undesirable, so I can revert those changes.
…mulacrum Add unit test for identifier Unicode emoji diagnostics Seems current diagnostics has some support for emoji usages, however it seems outdated and incomplete. This adds a simple unit test to showcase the status quo.
…rk-Simulacrum Update release notes for 1.64 This PR makes a few updates to the release notes to bring them on-par with the release notes of other releases: * The wording on some items has been changed to be more consistent and better describe what each change means, rather than using the PR title. * Items that were also in the compatibility notes have been removed from the other sections, only keeping them in the compat notes. * Diagnostics and ICE fixes have been removed from the notes. * The cargo section has been made more consistent. r? ``@Mark-Simulacrum`` cc ``@rust-lang/release`` ``@joshtriplett``
…i-obk interpret: expose generate_stacktrace without full InterpCx In Miri we sometimes want to emit diagnostics without having a full `&InterpCx` available. To avoid duplicating code, this adds a way to get a stacktrace from an arbitrary slice of interpreter frames, that Miri can use with access to just a thread manager.
…troalbini Try to clarify what's new in 1.64.0 ffi types
…umn, r=Dylan-DPC rustdoc: remove unused CSS `td.summary-column` It was added in 2a1bad7 to go with this module summary function: https://github.com/rust-lang/rust/blob/2a1bad70dd9bc99d8db54964108b42da8f4e9fbd/src/librustdoc/html/format.rs#L767-L780 The corresponding HTML was removed in 0a46933.
…=Mark-Simulacrum Add all submodules to the list of directories tidy skips Tidy contains a blacklist of directories that it is not visiting. This list is also used by the `replace-version-placeholder` tool added by rust-lang#100591 , to determine the directories to do its replacement from. Generally, tidy does not check submodules, but this is not done consistently for all submodules. This PR adds the submodules that were previously missing, so that the `replace-version-placeholder` tool does not attempt to change content of the books. This was needed because `rustc-dev-guide` contains the placeholder, leading to rust-lang#102014. Fixes rust-lang#102014
…=pietroalbini Remove backed off PRs from relnotes Backport of rust-lang@7358a9b to master.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=4 (queuing after everyhing that is prioritized right now) |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: a57a6ac2eb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (acb8934): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
from_waker,wakerandfrom_rawunstablyconst#101798 (Makefrom_waker,wakerandfrom_rawunstablyconst)late_bound#101881 (Remove an unused struct fieldlate_bound)td.summary-column#102005 (rustdoc: remove unused CSStd.summary-column)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup