Provide a sound method of flushing stdout #10218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method was unsound because you could very easily create two mutable pointers which alias the same location (not sound behavior). This hides the function which does so and then exports an explicit flush() function (with documentation about how it works).
bors
added a commit
that referenced
this pull request
Nov 1, 2013
The previous method was unsound because you could very easily create two mutable pointers which alias the same location (not sound behavior). This hides the function which does so and then exports an explicit flush() function (with documentation about how it works).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2023
…estion, r=dswij Add machine applicable suggestion for `bool_assert_comparison` Fixes rust-lang#7598 Also closes rust-lang#8118, it had already been fixed by an earlier change but I've added a test for it changelog: [`bool_assert_comparison`] The suggestion is now machine applicable
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
…tion, r=dswij Negate suggestions when needed in `bool_assert_comparison` changelog: none assuming this gets into the same release as rust-lang#10218 Fixes rust-lang#10291 r? `@dswij` Thanks to `@black-puppydog` for spotting it early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method was unsound because you could very easily create two mutable
pointers which alias the same location (not sound behavior). This hides the
function which does so and then exports an explicit flush() function (with
documentation about how it works).