Rollup of 11 pull requests #102223

matthiaskrgr · 2022-09-24T05:38:59Z

Successful merges:

Add a platform support document for Android #101780 (Add a platform support document for Android)
Remove RtlGenRandom (take two) #102044 (Remove RtlGenRandom (take two))
Adding ignore fuchsia tests for execvp (pre_exec) #102081 (Adding ignore fuchsia tests for execvp (pre_exec))
Adding ignore fuchsia non-applicable commands #102082 (Adding ignore fuchsia non-applicable commands)
rustdoc: CSS prevent sidebar width change jank #102146 (rustdoc: CSS prevent sidebar width change jank)
Calculate ProjectionTy::trait_def_id for return-position impl Trait in trait correctly #102152 (Calculate ProjectionTy::trait_def_id for return-position impl Trait in trait correctly)
Also require other subtrees to always build successfully #102175 (Also require other subtrees to always build successfully)
Add llvm-dis to the set of tools in ci-llvm #102176 (Add llvm-dis to the set of tools in ci-llvm)
Update doc after renaming fn is_zero #102188 (Update doc after renaming fn is_zero)
Improve rustdoc GUI tests #102199 (Improve rustdoc GUI tests)
Document some missing command-line arguments #102218 (Document some missing command-line arguments)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.

The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

`fn is_zero` has been renamed to `fn count_is_zero` in 1b1bf24. This patch updates the documentation accordingly.

This commit makes the `width` and `min-width` of the sidebar the same. They originally were when cad0fce added the `min-width` rule, but 6a5f8b1 changed the width without changing the `min-width`, causing it to sometimes oscilate between 200 and 250 pixels depending on the main content.

…shtriplett Add a platform support document for Android r? ``@joshtriplett``

…thomcc Remove `RtlGenRandom` (take two) First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.

…ore, r=tmandry Adding ignore fuchsia tests for execvp (pre_exec) Adding ignore fuchsia tests for pre_exec, which calls execvp cc. `@djkoloski` r? `@tmandry`

Adding ignore fuchsia non-applicable commands Adding ignore fuchsia non-applicable commands cc `@djkoloski` r? `@tmandry`

…r=GuillaumeGomez rustdoc: CSS prevent sidebar width change jank This commit makes the `width` and `min-width` of the sidebar the same. They originally were when cad0fce added the `min-width` rule, but 6a5f8b1 changed the `width` without changing the `min-width`, causing it to sometimes oscilate between 200 and 250 pixels depending on the main content. # Before [Screencast from 09-22-2022 10:25:29 AM.webm](https://user-images.githubusercontent.com/1593513/191813469-ea00f30f-6f49-40fc-9a26-e1dfd5068d2b.webm) # After [Screencast from 09-22-2022 10:32:20 AM.webm](https://user-images.githubusercontent.com/1593513/191813642-ae0902da-5262-403a-bbdf-995334201acb.webm)

…e1-dead Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly Fixes rust-lang#102140

…n514 Also require other subtrees to always build successfully r? ``@jyn514``

…ark-Simulacrum Add `llvm-dis` to the set of tools in `ci-llvm` The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

…n514 Update doc after renaming `fn is_zero` `fn is_zero` has been renamed to `fn count_is_zero` in 1b1bf24. This patch updates the documentation accordingly.

…-tests, r=notriddle Improve rustdoc GUI tests I finally finished the update so we can now store values in variables and use them. It improves things nicely. r? ``@notriddle``

Document some missing command-line arguments The rustc command-line arguments docs should document all of the stable arguments for rustc. Two were missing, `--force-warn` which was somewhat documented in the lint-levels chapter, but should also include a mention in the arguments list. `--diagnostic-width` was stabilized in rust-lang#95635, but the docs weren't updated.

matthiaskrgr · 2022-09-24T05:39:15Z

@bors r+ rollup=never p=11

bors · 2022-09-24T05:39:16Z

📌 Commit 4fc33e9 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-09-24T06:55:37Z

⌛ Testing commit 4fc33e9 with merge 199fe1d...

bors · 2022-09-24T09:36:23Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 199fe1d to master...

rust-timer · 2022-09-24T09:39:40Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#102218	f548f7af3b3ced3c20f613b3f7f2a3e1429782c4
#102199	38d3507aee0be5c7bd43c69f9d208a6630bb652c
#102188	13ee9827c8bb7ab9fea8aa7dd98f7bee299624e1
#102176	8f2903bc12d27a818f62aab5cdd830597859502b
#102175	d5bfd5a9ae277a57ea78726b4927fbda245e1522
#102152	fa97a6e48f3bed745a840635d2d784516ce2d13f
#102146	19525daf0830c2f4dc1feda59ffdda73612bd67b
#102082	231653164a7ab65c3c7664a138c1572e272b2a98
#102081	01008b2fc252356e5f4985b937cd354db2619445
#102044	e23ed91aca147c9bff738646a048a8daf7d733f0
#101780	3f0da21cbf005d0e64c973056fcb3585367631f6

previous master: 06968954f7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-24T10:55:02Z

Finished benchmarking commit (199fe1d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.3%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-2.3%, 2.7%]	3

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

ChrisDenton and others added 27 commits September 20, 2022 18:39

Remove RtlGenRandom (take two)

8ca6a27

First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.

Add a platform support document for Android

303a7dc

Add links to the Android platform support doc

47411d7

Adding ignore fuchsia tests for execvp (pre_exec)

b3d7e4e

Adding ignore fuchsia non-applicable commands

9808e10

Calculate ProjectionTy::trait_def_id correctly

79c665b

Also require other subtrees to always build successfully

7ed999b

Add llvm-dis to the set of tools in ci-llvm

cb8a9c4

The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Update doc after renaming fn is_zero

8eeeac6

`fn is_zero` has been renamed to `fn count_is_zero` in 1b1bf24. This patch updates the documentation accordingly.

rustdoc: add regression test for sidebar width jank

e3cb0a8

Update browser-ui-test version to 0.11.0

a4046e9

Improve GUI tests by using variables

d30cb5b

rustdoc: fix GUI tests to deal with slightly changed width

cd48154

Respond to document review feedback

7ad0ac7

Document some missing command-line arguments

f5f69bc

Rollup merge of rust-lang#101780 - chriswailes:android-platform, r=jo…

6fff4d9

…shtriplett Add a platform support document for Android r? ``@joshtriplett``

Rollup merge of rust-lang#102044 - ChrisDenton:BCrypt-system-rand, r=…

3baf5f8

…thomcc Remove `RtlGenRandom` (take two) First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.

Rollup merge of rust-lang#102081 - andrewpollack:add-execvp-calls-ign…

49ef55c

…ore, r=tmandry Adding ignore fuchsia tests for execvp (pre_exec) Adding ignore fuchsia tests for pre_exec, which calls execvp cc. `@djkoloski` r? `@tmandry`

Rollup merge of rust-lang#102082 - andrewpollack:uid-ignore, r=tmandry

6b67b0d

Adding ignore fuchsia non-applicable commands Adding ignore fuchsia non-applicable commands cc `@djkoloski` r? `@tmandry`

Rollup merge of rust-lang#102152 - compiler-errors:issue-102140, r=fe…

a842357

…e1-dead Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly Fixes rust-lang#102140

Rollup merge of rust-lang#102175 - oli-obk:miri_subtree_cleanup, r=jy…

00dfc32

…n514 Also require other subtrees to always build successfully r? ``@jyn514``

Rollup merge of rust-lang#102176 - ojeda:add-llvm-dis-to-ci-llvm, r=M…

0cd345c

…ark-Simulacrum Add `llvm-dis` to the set of tools in `ci-llvm` The LLVM disassembler is needed for the test introduced in rust-lang#97550. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Rollup merge of rust-lang#102188 - flba-eb:doc_missed_at_rename, r=jy…

be902e8

…n514 Update doc after renaming `fn is_zero` `fn is_zero` has been renamed to `fn count_is_zero` in 1b1bf24. This patch updates the documentation accordingly.

Rollup merge of rust-lang#102199 - GuillaumeGomez:improve-rustdoc-gui…

865e456

…-tests, r=notriddle Improve rustdoc GUI tests I finally finished the update so we can now store values in variables and use them. It improves things nicely. r? ``@notriddle``

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 24, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 24, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2022

bors merged commit 199fe1d into rust-lang:master Sep 24, 2022

bors mentioned this pull request Sep 24, 2022

Update doc after renaming fn is_zero #102188

Merged

rustbot added this to the 1.66.0 milestone Sep 24, 2022

This was referenced Sep 24, 2022

Add a platform support document for Android #101780

Merged

Support default-body trait functions with return-position impl Trait in traits #101679

Merged

matthiaskrgr deleted the rollup-wb1qdhk branch October 9, 2022 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 11 pull requests #102223

Rollup of 11 pull requests #102223

matthiaskrgr commented Sep 24, 2022

matthiaskrgr commented Sep 24, 2022

bors commented Sep 24, 2022

bors commented Sep 24, 2022

bors commented Sep 24, 2022

rust-timer commented Sep 24, 2022

rust-timer commented Sep 24, 2022

Rollup of 11 pull requests #102223

Rollup of 11 pull requests #102223

Conversation

matthiaskrgr commented Sep 24, 2022

matthiaskrgr commented Sep 24, 2022

bors commented Sep 24, 2022

bors commented Sep 24, 2022

bors commented Sep 24, 2022

rust-timer commented Sep 24, 2022

rust-timer commented Sep 24, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes