Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #102324

Merged
merged 12 commits into from
Sep 26, 2022
Merged

Rollup of 5 pull requests #102324

merged 12 commits into from
Sep 26, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fmease and others added 12 commits September 23, 2022 21:51
@fmease
Allow more !Copy impls
28e0c5a
@inquisitivecrystal
Add regression test for issue rust-lang#100878
ad05b32
@compiler-errors
Recover some items that expect braces and don't take semicolons
4d0d688
@lilasta
Allow ~const bounds on non-const functions
e4b08ab
@b-naber
don't duplicate late-bound region names in print of Binder
456f4e8
@b-naber
bless tests
897adb8
@b-naber
address review
6118ee3
@matthiaskrgr
Rollup merge of rust-lang#101875 - fmease:allow-more-negative-copy-im…
4d4a369 
…pls, r=lcnr

Allow more `!Copy` impls

You can already implement `!Copy` for a lot of types (with `#![feature(negative_impls)]`). However, before this PR you could not implement `!Copy` for ADTs whose fields don't implement `Copy` which didn't make any sense. Further, you couldn't implement `!Copy` for types impl'ing `Drop` (equally nonsensical).

``@rustbot`` label T-types F-negative_impls
Fixes rust-lang#101836.

r? types
@matthiaskrgr
Rollup merge of rust-lang#101996 - b-naber:binder-print, r=lcnr
b02062e 
Don't duplicate region names for late-bound regions in print of Binder

Fixes rust-lang#101280
@matthiaskrgr
Rollup merge of rust-lang#102181 - inquisitivecrystal:issue-100878-te…
0857dde 
…st, r=Mark-Simulacrum

Add regression test

This adds a regression test for issue rust-lang#100878.

Closes rust-lang#100878.
@matthiaskrgr
Rollup merge of rust-lang#102273 - woppopo:relax_const_bound, r=fee1-…
e9bec2f 
…dead

Allow `~const` bounds on non-const functions

Makes the behavior of bound of trait-associated functions and non-associated functions consistent.
@matthiaskrgr
Rollup merge of rust-lang#102286 - compiler-errors:recover-semi-in-bl…
6f5e8c2 
…ock-item, r=davidtwco

Recover some items that expect braces and don't take semicolons

Fixes rust-lang#102262
@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 26, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Sep 26, 2022

📌 Commit 6f5e8c2 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 26, 2022
@bors
Copy link
Contributor

bors commented Sep 26, 2022

⌛ Testing commit 6f5e8c2 with merge 8b70583...

@bors
Copy link
Contributor

bors commented Sep 26, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8b70583 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2022
@bors bors merged commit 8b70583 into rust-lang:master Sep 26, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 26, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#102286 e744e69058e8e6cc8c21f59658c510d3d50447e6
#102273 3086a1c41168fcc8f6273ccf36258e8bf7e607c5
#102181 34351e9113d2d1727b865806380c50a1ab0262c3
#101996 4c922d246daaf002b8890cbc808c0fc8aa23a702
#101875 5aa83d0012f98f8abd49bba3b33eeea405ee5a9c

previous master: 1d1f142660

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Sep 26, 2022
Merged
Merged
Closed
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8b70583): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 1.4% [1.3%, 1.6%] 6
Improvements ✅
(primary)		 -0.7% [-0.9%, -0.6%] 6
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.5% [-0.9%, 0.7%] 7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 3.7% [3.7%, 3.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) 3.7% [3.7%, 3.7%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.4% [1.8%, 2.7%] 4
Regressions ❌
(secondary)		 2.6% [2.6%, 2.7%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.4% [1.8%, 2.7%] 4

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added the perf-regression Performance regression. label Sep 26, 2022
@nnethercote
Copy link
Contributor

keccak is noisy at the moment.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 27, 2022
@davidtwco davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-6l70oz3 branch October 9, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet