Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require lifetime bounds for opaque types in order to allow hidden types to capture said lifetimes #102417

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Require lifetime bounds for opaque types in order to allow hidden types to capture said lifetimes #102417

merged 1 commit into from
Oct 20, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 28, 2022

fixes #96996

cc @aliemjay

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 28, 2022
@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2022
@jackh726
Copy link
Member

jackh726 commented Oct 7, 2022

r? @jackh726

@rust-highfive rust-highfive assigned jackh726 and unassigned TaKO8Ki Oct 7, 2022
@bors
Copy link
Contributor

bors commented Oct 14, 2022

☔ The latest upstream changes (presumably #102700) made this pull request unmergeable. Please resolve the merge conflicts.

@jackh726
Copy link
Member

@bors r+ rollup=never

While unstable, this a "breaking change" for TAITs, so I'd rather this not land in a rollup, so bisection will be easier for the inevitable issues filed.

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit 1dc2119 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@bors
Copy link
Contributor

bors commented Oct 19, 2022

⌛ Testing commit 1dc2119 with merge 1e5d3a66a9b79074d8bfe520b64eb62707e9beb0...

@bors
Copy link
Contributor

bors commented Oct 19, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 19, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit 1dc2119 with merge cb94675...

@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing cb94675 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 20, 2022
@bors bors merged commit cb94675 into rust-lang:master Oct 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 20, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cb94675): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% [-1.1%, -1.1%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-4.4%, -2.7%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@camsteffen camsteffen mentioned this pull request Oct 22, 2022
Merged
@oli-obk oli-obk mentioned this pull request Nov 2, 2022
Merged
@oli-obk oli-obk deleted the opaque_lifetimes2 branch November 9, 2022 10:16
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#103876 - oli-obk:tait_implications, r=lcnr
3617adf 
type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds

fixes rust-lang#103642

rust-lang#102417 only made sure that hidden types cannot outlive lifetimes other than the ones mentioned on bounds, but didn't allow us to actually infer anything from that.

cc `@aliemjay`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102417 - oli-obk:opaque_lifetimes2, r=jackh726
70bbf28 
Require lifetime bounds for opaque types in order to allow hidden types to capture said lifetimes

fixes rust-lang#96996

cc `@aliemjay`
oli-obk added a commit to oli-obk/rust that referenced this pull request Aug 30, 2023
@oli-obk
Revert "Auto merge of rust-lang#102417 - oli-obk:opaque_lifetimes2, r…
e0a60f0 
…=jackh726"

This reverts commit cb94675, reversing
changes made to 57781b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

type-alias-impl-trait implicitly captures lifetime params
9 participants
@oli-obk @rust-highfive @jackh726 @bors @rust-log-analyzer @rust-timer @compiler-errors @TaKO8Ki @rustbot