error parsing lifetime following by Sized and message + between them

[lyming2007]

Fixes #102598

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

[compiler-errors]

I still don't know if this code should live in parse_param_general -- it seems like a very specific place to put this fix, so similar typos still don't have a suggestion, both in different positions (e.g. return position) and similar in nature (e.g. impl Sized 'a)

[lyming2007]

I still don't know if this code should live in parse_param_general -- it seems like a very specific place to put this fix, so similar typos still don't have a suggestion, both in different positions (e.g. return position) and similar in nature (e.g. impl Sized 'a)

at least parse_param_general is safe for this code, because that 'lifetime + trait appears as parameters for function, though the code is rare as you mentioned before.

[wesleywiser]

r? @compiler-errors

since you're already looking at it 🙂

[compiler-errors]

Sorry I have neglected reviewing this.

I'm still not convinced this is worth the extra code, since it's not as general as I would like it to be -- but that's just my opinion, and I'd rather not continue accidentally blocking this PR since I've been distracted.

[compiler-errors]

Let's get someone else's opinion on this. Sorry again about letting this PR sit around for so long, totally my fault.

r? compiler

[lyming2007]

Let's get someone else's opinion on this. Sorry again about letting this PR sit around for so long, totally my fault.

r? compiler

Thanks Michael. Your suggestions are really helpful. I'll investigate more.

[lyming2007]

I still don't know if this code should live in parse_param_general -- it seems like a very specific place to put this fix, so similar typos still don't have a suggestion, both in different positions (e.g. return position) and similar in nature (e.g. impl Sized 'a)

I think you're right, the code shouldn't be in parse_param_general after carefully thinking about it. Now I moved it to parse_impl_ty which seems to be more general.

[jackh726]

@bors r+

[bors]

📌 Commit 419df5f has been approved by jackh726

It is now in the queue for this repository.

[bors]

⌛ Testing commit 419df5f with merge 58f5a01...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 58f5a01 to master...

[rust-timer]

Finished benchmarking commit (58f5a01): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.