Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up maybe_uninit_as_bytes API #103128

Closed
wants to merge 1 commit into from
Closed

Tidy up maybe_uninit_as_bytes API #103128

wants to merge 1 commit into from

Conversation

SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Oct 16, 2022 •
edited

  • Follow mut naming conversion
  • Move methods to extensions

The diff is super weird because it misunderstood what was moved.

@SUPERCILEX
Tidy up maybe_uninit_as_bytes API
6d94914 
- Follow mut naming conversion
- Move types to extensions

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@scottmcm scottmcm assigned scottmcm and unassigned joshtriplett Oct 17, 2022
@scottmcm
Copy link
Member

Thanks for the PR!

While I'm sometimes willing to add new APIs without libs-api assent, I'm much more worried about churning signatures without contacting them to see if they like them, since it would be a shame to find out they didn't and have to revert it and have impacted nightly users unnecessarily.

Could you please file an ACP for this set of changes (I think #103128 #103130 #103131 could probably all be one) to get a "yup, that seems better" from the team?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
This was referenced Oct 17, 2022
Closed
Closed
@SUPERCILEX SUPERCILEX mentioned this pull request Oct 17, 2022
Closed
@SUPERCILEX
Copy link
Contributor Author

Sounds good! Created rust-lang/libs-team#123

@SUPERCILEX
Copy link
Contributor Author

Gonna nuke these methods, see rust-lang/libs-team#122 (comment)

@SUPERCILEX SUPERCILEX closed this Oct 18, 2022
@SUPERCILEX SUPERCILEX deleted the uninit-bytes branch October 18, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SUPERCILEX @rustbot @rust-highfive @scottmcm @joshtriplett