Factor out conservative_is_privately_uninhabited

[camsteffen]

After #102660 there is no more need for conservative_is_privately_uninhabited.

r? @oli-obk

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[camsteffen]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1b7eb73a059e04a0a8c4e88855ab8e12d2f664a3 with merge 523265f2409bfcee2b3fe7157a528e09edd9123e...

[bors]

☀️ Try build successful - checks-actions
Build commit: 523265f2409bfcee2b3fe7157a528e09edd9123e (523265f2409bfcee2b3fe7157a528e09edd9123e)

[rust-timer]

Queued 523265f2409bfcee2b3fe7157a528e09edd9123e with parent 758f196, future comparison URL.

[rust-timer]

Finished benchmarking commit (523265f2409bfcee2b3fe7157a528e09edd9123e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[0.2%, 2.4%]	2
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.2%]	17
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	-0.4%	[-0.5%, -0.2%]	17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.5%, 3.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-5.4%, -3.6%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[oli-obk]

r=me with tests reinstated and comments updated (maybe just make them links to the issues?)

@bors delegate+

[bors]

✌️ @camsteffen can now approve this pull request

[camsteffen]

@bors r=oli-obk

[bors]

📌 Commit 9239cdea9d481531ffc9a2eee1680716ce20fcf2 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9239cdea9d481531ffc9a2eee1680716ce20fcf2 with merge b307b17b29af3dc4e7db9b41f8a6e80c9a394221...

[bors]

💔 Test failed - checks-actions

[camsteffen]

The failed test was just removed in #104571 so I probably just need a rebase.

@bors r=oli-obk

[bors]

📌 Commit cc8dddb has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit cc8dddb with merge 736c675...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 736c675 to master...

[rust-timer]

Finished benchmarking commit (736c675): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.9%, -0.2%]	22
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	-0.4%	[-0.9%, -0.2%]	22

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[0.9%, 5.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-3.4%, -0.5%]	4
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-0.1%	[-3.4%, 5.2%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.1%, -2.0%]	3
All ❌✅ (primary)	-	-	0