Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change #[suggestion_*] attributes to use style="..." #103575

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Change #[suggestion_*] attributes to use style="..." #103575

merged 5 commits into from
Nov 2, 2022

Commits on Oct 26, 2022

  1. Add style= parameter to suggestion attributes

    @Xiretza
    Xiretza committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    368c4a3 View commit details
    Browse the repository at this point in the history

  2. rustfmt diagnostic derive tests

    @Xiretza
    Xiretza committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    29334b9 View commit details
    Browse the repository at this point in the history

  3. Add "tool-only" suggestion style

    @Xiretza
    Xiretza committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    20f2958 View commit details
    Browse the repository at this point in the history

  4. Convert all #[suggestion_*] attributes to #[suggestion(style = "...")] 

    Using the following command:

find compiler/ -type f -name '*.rs' -exec perl -i -gpe \
    's/(#\[\w*suggestion)_(short|verbose|hidden)\(\s*(\S+,)?/\1(\3style = "\2",/g' \
    '{}' +
    @Xiretza
    Xiretza committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    cd621be View commit details
    Browse the repository at this point in the history

  5. Remove #[suggestion_*] attributes

    @Xiretza
    Xiretza committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2eeb780 View commit details
    Browse the repository at this point in the history