Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ rust-analyzer #103579

Merged
merged 53 commits into from Oct 27, 2022
Merged

⬆️ rust-analyzer #103579

merged 53 commits into from Oct 27, 2022

Commits on Sep 27, 2022

  1. Don't auto-publish lib crates

    Veykril committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f310d4c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    d7fb8d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Configuration menu
    Copy the full SHA
    d5f467a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Auto merge of rust-lang#13399 - DropDemBits:assists-format-args-captu…

    …re-pt2, r=Veykril
    
    Migrate assists to format args captures, part 2
    
    Continuation of rust-lang#13379
    
    Migrates:
    
    - `generate_constant`
    - `generate_default_from_enum_variant`
    - `generate_default_from_new`
    - `generate_delegate_methods`
    - `generate_deref`
    - `generate_documentation_template`
    - `generate_enum_is_method`
    - `generate_enum_projection_method`
    - `generate_from_impl_for_enum`
    - `generate_function`
    - `generate_getter`
    - `generate_impl`
    - `generate_new`
    - `generate_setter`
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a2e4f78 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13423 - Veykril:vscode-vars, r=Veykril

    Substitute some VSCode variables in the VSCode client
    
    cc rust-lang/rust-analyzer#13405
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    40cbeb5 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#13302 - Veykril:auto-publish, r=Veykril

    Don't auto-publish lib crates
    
    I believe this should *just* work? With this cargo-workspaces should not consider them
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    f079792 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f43597 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8aaafdd View commit details
    Browse the repository at this point in the history
  6. Make more things private

    Veykril committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d68616a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0421756 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7b5c943 View commit details
    Browse the repository at this point in the history
  9. Cleanup output channels

    Veykril committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d63c44e View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#13426 - Veykril:client-refactor, r=Veykril

    Refactor language client handling
    
    Follow up to rust-lang/rust-analyzer#12847 (turns out they fixed parts of the problem)
    
    The PR will attempt to allow us to dispose more resources at will, so that we can implement restarts for the server properly instead of restating the entire extension as well as allowing us to implement a stop command.
    
    Closes rust-lang/rust-analyzer#12936
    Closes rust-lang/rust-analyzer#4697
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    067c410 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e41023c View commit details
    Browse the repository at this point in the history
  12. Auto merge of rust-lang#13427 - Veykril:cancel-check, r=Veykril

    feat: Make flycheck workdone progress reports cancellable
    
    In clients that support this (like VSCode), the clients will now render a cancel button on the notification message which can be clicked to cancel the flycheck instead.
    
    Closes rust-lang/rust-analyzer#6895
    ![Code_VbXgP3SbFD](https://user-images.githubusercontent.com/3757771/196205329-2df93451-c143-4d1b-a700-d988edf55efa.gif)
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    106285b View commit details
    Browse the repository at this point in the history
  13. fix: Fix formatting requests hanging when r-a is still starting

    The reason for that was that we were calculating the crate defmaps
    of the file we are saving by accident causing us to get stuck waiting
    on their expensive computation, while we only need the relevant crate
    id.
    Veykril committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a762bac View commit details
    Browse the repository at this point in the history
  14. Auto merge of rust-lang#13428 - Veykril:fmt-stuck, r=Veykril

    fix: Fix formatting requests hanging when r-a is still starting
    
    The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id.
    
    Closes rust-lang/rust-analyzer#4054
    Closes rust-lang/rust-analyzer#11654
    bors committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    4d4c05d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Configuration menu
    Copy the full SHA
    8047512 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13433 - rust-lang:revert-13354-try-stuff, r=V…

    …eykril
    
    Revert "feat: Diagnose some incorrect usages of the question mark operator"
    
    Reverts rust-lang/rust-analyzer#13354
    
    It seems like we are getting stuck with inference variables here, not just placeholders and errors so there is probably more wrong here that I don't understand. Reverting seems like the best solution right now as I don't have the time to look into this this week.
    bors committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    97b357e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Simplify

    Veykril committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9d3e616 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3392573 View commit details
    Browse the repository at this point in the history
  3. Add some sysroot logging

    Veykril committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    653dafa View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#13441 - Veykril:sysroot-logging, r=Veykril

    Add some sysroot logging
    bors committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    82ac6f7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e2c41d View commit details
    Browse the repository at this point in the history
  6. Implement invocation strategy config for checkOnSave

    Note that due to how cargo works, none of the modes currently work for r-a
    Veykril committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4a287d2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5174b65 View commit details
    Browse the repository at this point in the history
  8. {manifest-path} interpolation

    Veykril committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7db5029 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4673236 View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#13128 - Veykril:invocation-strategy, r=Veykril

    Implement invocation strategy config
    
    Fixes rust-lang/rust-analyzer#10793
    
    This allows to change how we run build scripts (and `checkOnSave`), exposing two configs:
    - `once`: run the specified command once in the project root (the working dir of the server)
    - `per_workspace`: run the specified command per workspace in the corresponding workspace
    
    This also applies to `checkOnSave` likewise, though `once_in_root` is useless there currently, due to rust-lang/cargo#11007
    bors committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    a77ac93 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    69b8456 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13444 - Veykril:rethrow-err, r=Veykril

    fix: Don't catch the server activation error
    
    We are are rethrowing and showing errors higher up in the call stack already. This just ate the error hiding the stacktrace unnecessarily.
    bors committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    32614e2 View commit details
    Browse the repository at this point in the history
  3. feat: add multiple getters mode in generate_getter

    This commit adds two modes to generate_getter action.
    First, the plain old working on single fields.
    Second, working on a selected range of fields.
    feniljain committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5bff6c5 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#13365 - feniljain:master, r=Veykril

    feat: add multiple getters mode in `generate_getter`
    
    This commit adds two modes to generate_getter action.
    First, the plain old working on single fields.
    Second, working on a selected range of fields.
    
    Should partially solve rust-lang#13246
    If this gets approved will create a separate PR for setters version of the same
    
    ### Points to help in review:
    
    - `generate_getter_from_record_info` contains code which is mostly taken from assist before refactor
    - Same goes for `parse_record_fields`
    - There are changes in other assists, as one of the methods in utils named `find_struct_impl` is changed, before it used to accept a single `fn_name`, now it takes a list of function names to check against. All old impls are updated to create a small list to pass their single element.
    
    ### Assumptions:
    
    - If any of the fields have an implementation, the action will quit.
    bors committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f3cce5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    de195ff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e05df93 View commit details
    Browse the repository at this point in the history
  7. Auto merge of rust-lang#13448 - yotamofek:python-ext-polyfill-workaro…

    …und, r=Veykril
    
    Workaround the python vscode extension's polyfill
    
    Fixes rust-lang#13442
    
    `String.replaceAll` and `String.replace` behave the same when given a (/g-flagged) Regex, so fix is very simple.
    bors committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    7741e3d View commit details
    Browse the repository at this point in the history
  8. Auto merge of rust-lang#13447 - Veykril:didsavedoc-block, r=Veykril

    fix: Fix DidSaveDocument requests blocking the server on startup
    
    Follow up to rust-lang/rust-analyzer#13428
    Fixes rust-lang/rust-analyzer#13434
    bors committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2481721 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a8e0a20 View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#13451 - Veykril:lang-config, r=Veykril

    internal: Properly handle language configuration config changes
    bors committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    69f01fd View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Configuration menu
    Copy the full SHA
    1cb4607 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13453 - Veykril:disabled-commands, r=Veykril

    internal: Properly handle commands in the VSCode client when the server is stopped
    bors committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    8ee23f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. scip: minor clean-ups

    Avoids a couple redundant hash map lookups and so.
    emilio committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    7ee7225 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd49d01 View commit details
    Browse the repository at this point in the history
  3. scip: Rewrite tests to be closer to what we actually do.

    It's also less code.
    emilio committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ec6d72b View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#13461 - emilio:ide-cleanup-continue, r=Veykril

    ide: Remove unnecessary continue.
    
    Just a minor clean-up I found while going through the code.
    bors committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    b643dd6 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#13460 - emilio:scip-cleanups, r=Veykril

    scip: minor clean-ups
    
    Avoids a couple redundant hash map lookups and so.
    bors committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    d3b7e94 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6459d7f View commit details
    Browse the repository at this point in the history
  7. Auto merge of rust-lang#13463 - lowr:fix/builtin-derive-with-const-ge…

    …nerics, r=Veykril
    
    Support const generics for builtin derive macro
    
    Fixes rust-lang#13121
    
    We have been treating every generic parameter as type parameter during builtin derive macro expansion. This patch adds support for const generics in such expansions.
    bors committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    19efa0b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0f8904e View commit details
    Browse the repository at this point in the history
  9. Auto merge of rust-lang#13466 - Veykril:invocation-location, r=Veykril

    Implement invocation location config
    
    This allows setting the working directory for build-scripts on flycheck
    Complements rust-lang/rust-analyzer#13128
    
    This will be followed up by one more PR that adds a few simple interpolation vars for `overrideCommand`, with that we should cover the needs for most build systems I believe.
    bors committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    b25f657 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Configuration menu
    Copy the full SHA
    859f559 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#13471 - Veykril:invoc-strategy-once, r=Veykril

    Handle multiple projects sharing dependency correctly in `once` strategy
    bors committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    43fb956 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. ⬆️ rust-analyzer

    lnicola committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    22a6bc4 View commit details
    Browse the repository at this point in the history