fix: Unexpected trait bound not satisfied in HRTB and Associated Type #103695

LYF1999 · 2022-10-28T16:01:23Z

rustbot · 2022-10-28T16:01:30Z

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2022-10-28T16:46:42Z

@LYF1999, please provide a more thorough description in the PR for why you think this fixes the issue, since the change is in some pretty fundamental trait selection code.

LYF1999 · 2022-10-28T17:20:11Z

there is code can produce this bug. And it's not about GAT.

use std::fmt::Debug;

fn main() {
    let mut log_service = LogService { inner: Inner };
    log_service.call(Struct1 {});
}

pub trait Service<Request> {
    type Response;

    fn call(&mut self, req: Request) -> Self::Response;
}

pub struct LogService<S> {
    inner: S,
}

impl<T, S, U> Service<T> for LogService<S>
where
    S: Service<T, Response = U>,
    U: for<'a> Extension<'a>,
    for<'a> <U as Extension<'a>>::Item: std::fmt::Debug,
{
    type Response = S::Response;

    fn call(&mut self, req: T) -> Self::Response {
        self.inner.call(req)
    }
}

pub struct Inner;

impl Service<Struct1> for Inner {
    type Response = Resp;

    fn call(&mut self, req: Struct1) -> Self::Response {
        Resp::A(req)
    }
}

pub trait Extension<'a> {
    type Item;
}

pub trait E2
where
    Self: for<'a> Extension<'a>,
{
    fn touch<F>(self, f: F) -> Self
    where
        F: for<'b> Fn(<Self as Extension<'b>>::Item);
}

#[derive(Debug)]
pub struct Struct1 {}

pub enum Resp {
    A(Struct1),
}

impl<'a> Extension<'a> for Resp {
    type Item = RespItem<'a>;
}

impl E2 for Resp {
    fn touch<F>(self, f: F) -> Self
    where
        F: for<'b> Fn(<Self as Extension<'b>>::Item),
    {
        match &self {
            Resp::A(a) => f(RespItem::A(a)),
        }
        self
    }
}

pub enum RespItem<'a> {
    A(&'a Struct1),
}

impl Debug for RespItem<'_> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::A(arg0) => f.debug_tuple("A").field(arg0).finish(),
        }
    }
}

compiler try to evaluate predicate for<'a> <U as Extension<'a>>::Item: std::fmt::Debug.
in this context, fn evaluate_trait_predicate_recursively gets a obligation <Resp<'a> as Extension<'a>>::Item: Debug.
but fn candidate_from_obligation assemble 0 candidate for <Resp<'a> as Extension<'a>>::Item: Debug.
So this code failed.
there are some ways to resolve that:

normalize <Resp<'a> as Extension<'a>>::Item: Debug to RespItem<'a>: Debug and evaluate it.
normalize <Resp<'a> as Extension<'a>>::Item: Debug in candidate_from_obligation and assemble 1 candidate ImplCandidate. but fn rematch_impl will check ImplCandidate.

@compiler-errors

davidtwco · 2022-10-31T14:55:13Z

r? rust-lang/types

jackh726 · 2022-11-07T02:33:35Z

@bors try @rust-timer queue

bors · 2022-11-07T02:33:45Z

⌛ Trying commit 125e9aae4db14716e2ac438806fd4b036ff01872 with merge b84d21ad268a5a9a3962aae7e6d9543ed1a2ac90...

bors · 2022-11-07T05:14:47Z

☀️ Try build successful - checks-actions
Build commit: b84d21ad268a5a9a3962aae7e6d9543ed1a2ac90 (b84d21ad268a5a9a3962aae7e6d9543ed1a2ac90)

rust-timer · 2022-11-07T07:36:07Z

Finished benchmarking commit (b84d21ad268a5a9a3962aae7e6d9543ed1a2ac90): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.2%, 1.4%]	2
Regressions ❌ (secondary)	3.1%	[0.4%, 4.1%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.9%, -0.6%]	4
All ❌✅ (primary)	1.3%	[1.2%, 1.4%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	6.4%	[6.4%, 6.4%]	1
Improvements ✅ (primary)	-0.7%	[-1.2%, -0.5%]	3
Improvements ✅ (secondary)	-2.2%	[-2.3%, -2.0%]	3
All ❌✅ (primary)	-0.2%	[-1.2%, 1.5%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	2.1%	[1.8%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	2
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

LYF1999 · 2022-11-10T03:29:35Z

@bors try @rust-timer queue

rfcbot · 2023-02-02T13:56:30Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-02-12T13:56:56Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler/rustc_trait_selection/src/traits/select/mod.rs

lcnr

r=me after the final change

lcnr · 2023-02-13T09:30:29Z

r? @lcnr

lcnr · 2023-02-14T09:52:06Z

@bors r+

bors · 2023-02-14T09:52:09Z

📌 Commit d164448 has been approved by lcnr

It is now in the queue for this repository.

bors · 2023-02-14T10:01:22Z

⌛ Testing commit d164448 with merge 9bb6e60...

bors · 2023-02-14T13:08:14Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 9bb6e60 to master...

rust-timer · 2023-02-14T14:26:34Z

Finished benchmarking commit (9bb6e60): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

lcnr · 2023-03-08T11:49:27Z

compiler/rustc_trait_selection/src/traits/select/mod.rs

+                    let mut nested_result = EvaluationResult::EvaluatedToOk;
+                    for obligation in nested_obligations {
+                        nested_result = cmp::max(
+                            this.evaluate_predicate_recursively(stack.list(), obligation)?,


afaict this uses the stack which already includes the current goal, so we get a coinductive cycle in #108897. Have to pop the element pushed in line 988 before recursing so that the stack isn't invalid.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Sadly, the patch to reduce the cargo verbosity no longer applies, so I've asked upstream about the proper way to get the old result. (so the build log becomes Quite Bloated for now). Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

rustbot assigned davidtwco Oct 28, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2022

LYF1999 changed the title ~~fix: Unexpected trait bound not satisfied in HRTB~~ fix: Unexpected trait bound not satisfied in HRTB and Associated Type Oct 28, 2022

LYF1999 force-pushed the yf/103563 branch from 15d856b to 5ec007e Compare October 28, 2022 16:34

This comment has been minimized.

Sign in to view

LYF1999 force-pushed the yf/103563 branch 3 times, most recently from b6933a3 to 34296df Compare October 30, 2022 14:49

This comment has been minimized.

Sign in to view

LYF1999 force-pushed the yf/103563 branch from 34296df to 125e9aa Compare October 30, 2022 16:49

rustbot assigned jackh726 and unassigned davidtwco Oct 31, 2022

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2022

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 7, 2022

LYF1999 force-pushed the yf/103563 branch 2 times, most recently from cdad124 to 74fc706 Compare November 10, 2022 03:11

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Feb 12, 2023

rfcbot added the to-announce Announce this issue on triage meeting label Feb 12, 2023

lcnr reviewed Feb 13, 2023

View reviewed changes

compiler/rustc_trait_selection/src/traits/select/mod.rs Outdated Show resolved Hide resolved

lcnr reviewed Feb 13, 2023

View reviewed changes

rustbot assigned lcnr and unassigned oli-obk Feb 13, 2023

fix: Unexpected trait bound not satisfied in HRTB

d164448

LYF1999 force-pushed the yf/103563 branch from 701af68 to d164448 Compare February 13, 2023 11:40

LYF1999 requested a review from lcnr February 13, 2023 13:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 14, 2023

bors merged commit 9bb6e60 into rust-lang:master Feb 14, 2023

rustbot added this to the 1.69.0 milestone Feb 14, 2023

bors mentioned this pull request Feb 14, 2023

add with_hash_task to generate DepNode deterministically #100987

Closed

apiraino removed the to-announce Announce this issue on triage meeting label Feb 16, 2023

clubby789 mentioned this pull request Mar 7, 2023

ICE with Axum #108847

Open

LYF1999 mentioned this pull request Mar 8, 2023

Unexpected build pass with a not Send future #108897

Closed

lcnr reviewed Mar 8, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Unexpected trait bound not satisfied in HRTB and Associated Type #103695

fix: Unexpected trait bound not satisfied in HRTB and Associated Type #103695

LYF1999 commented Oct 28, 2022

rustbot commented Oct 28, 2022

compiler-errors commented Oct 28, 2022

LYF1999 commented Oct 28, 2022

This comment has been minimized.

This comment has been minimized.

davidtwco commented Oct 31, 2022

jackh726 commented Nov 7, 2022

This comment has been minimized.

bors commented Nov 7, 2022

bors commented Nov 7, 2022

This comment has been minimized.

rust-timer commented Nov 7, 2022

LYF1999 commented Nov 10, 2022

rfcbot commented Feb 2, 2023

rfcbot commented Feb 12, 2023

lcnr left a comment

lcnr commented Feb 13, 2023

lcnr commented Feb 14, 2023

bors commented Feb 14, 2023

bors commented Feb 14, 2023

bors commented Feb 14, 2023

rust-timer commented Feb 14, 2023

lcnr Mar 8, 2023 •

edited

LYF1999 Mar 8, 2023

fix: Unexpected trait bound not satisfied in HRTB and Associated Type #103695

fix: Unexpected trait bound not satisfied in HRTB and Associated Type #103695

Conversation

LYF1999 commented Oct 28, 2022

rustbot commented Oct 28, 2022

compiler-errors commented Oct 28, 2022

LYF1999 commented Oct 28, 2022

This comment has been minimized.

This comment has been minimized.

davidtwco commented Oct 31, 2022

jackh726 commented Nov 7, 2022

This comment has been minimized.

bors commented Nov 7, 2022

bors commented Nov 7, 2022

This comment has been minimized.

rust-timer commented Nov 7, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

LYF1999 commented Nov 10, 2022

rfcbot commented Feb 2, 2023

rfcbot commented Feb 12, 2023

lcnr left a comment

Choose a reason for hiding this comment

lcnr commented Feb 13, 2023

lcnr commented Feb 14, 2023

bors commented Feb 14, 2023

bors commented Feb 14, 2023

bors commented Feb 14, 2023

rust-timer commented Feb 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

lcnr Mar 8, 2023 • edited

Choose a reason for hiding this comment

LYF1999 Mar 8, 2023

Choose a reason for hiding this comment

lcnr Mar 8, 2023 •

edited