Remove save-analysis. #101841

nnethercote · 2022-09-15T07:42:15Z

Most tests involving save-analysis were removed, but I kept a few where the -Zsave-analysis was an add-on to the main thing being tested, rather than the main thing being tested.

Closes #43606

rustbot · 2022-09-15T07:42:20Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

nnethercote · 2022-09-15T07:44:09Z

#43606 is the tracking issue for save analysis removal.

src/test/ui/issues/issue-3763.rs

src/test/ui/traits/alias/self-in-generics.rs

src/test/ui/type-alias-impl-trait/issue-63279.rs

src/test/ui/feature-gates/feature-gate-associated_type_bounds.rs

src/test/ui/asm/issue-72570.rs

src/test/ui/methods/assign-to-method.rs

nnethercote · 2022-09-15T10:16:29Z

@bors try @rust-timer queue

rust-timer · 2022-09-15T10:16:30Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-15T10:16:37Z

⌛ Trying commit f4d60e6cf969a8262f3fac33eb243c1294ff54cb with merge 19e674d3ec94f9dd85de3348e63ebb4baa3d91df...

bors · 2022-09-15T12:07:05Z

☀️ Try build successful - checks-actions
Build commit: 19e674d3ec94f9dd85de3348e63ebb4baa3d91df (19e674d3ec94f9dd85de3348e63ebb4baa3d91df)

rust-timer · 2022-09-15T12:07:07Z

Queued 19e674d3ec94f9dd85de3348e63ebb4baa3d91df with parent 0a27ac1, future comparison URL.

rust-timer · 2022-09-15T14:28:34Z

Finished benchmarking commit (19e674d3ec94f9dd85de3348e63ebb4baa3d91df): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-0.6%	[-3.0%, 1.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.1%, 2.0%]	2

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

est31 · 2022-09-15T14:50:12Z

Would it be possible to wait with merging of this, maybe 2-3 weeks? Due to this PR, I've switched cargo-udeps over to use binary depinfo, and made the 0.1.33 release, but it needs some time until the update arrives at users. On the other hand cargo-udeps has to be used with nightly rustc, so a removal would get to them very quickly.

lqd · 2022-09-15T19:14:49Z

@est31 there's a bit more work to be done here related to rustup, and will need FCP I think (which lasts at least 10 days or so IIRC), so there's time yeah.

nnethercote · 2022-09-15T20:45:45Z

The perf run shows that bootstrap time was reduced by about 4.6 seconds due to the removal of the rust_save_analysis crate.

nnethercote · 2022-09-16T00:54:45Z

I addressed all the comments about tests.

oli-obk · 2022-09-16T07:49:46Z

@rfcbot merge

The save-analysis framework has few users and all of them are willing to move away from it. We've sat on the removal plan for two years now without arguments for keeping it further.

rfcbot · 2022-09-16T07:49:47Z

rust-timer · 2023-02-16T15:25:26Z

Finished benchmarking commit (af3c8b2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[4.7%, 4.7%]	1
Regressions ❌ (secondary)	1.8%	[1.0%, 2.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	4.7%	[4.7%, 4.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Sadly, the patch to reduce the cargo verbosity no longer applies, so I've asked upstream about the proper way to get the old result. (so the build log becomes Quite Bloated for now). Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

nnethercote mentioned this pull request Sep 15, 2022

Tracking issue for -Zsave-analysis #43606

Closed

bjorn3 reviewed Sep 15, 2022

View reviewed changes

src/test/ui/issues/issue-3763.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Sep 15, 2022

View reviewed changes

src/test/ui/traits/alias/self-in-generics.rs Outdated Show resolved Hide resolved

src/test/ui/type-alias-impl-trait/issue-63279.rs Outdated Show resolved Hide resolved

JohnTitor reviewed Sep 15, 2022

View reviewed changes

src/test/ui/feature-gates/feature-gate-associated_type_bounds.rs Outdated Show resolved Hide resolved

JohnTitor reviewed Sep 15, 2022

View reviewed changes

src/test/ui/asm/issue-72570.rs Outdated Show resolved Hide resolved

lqd reviewed Sep 15, 2022

View reviewed changes

src/test/ui/methods/assign-to-method.rs Outdated Show resolved Hide resolved

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 15, 2022

nnethercote force-pushed the rm-save-analysis branch from f4d60e6 to ded8635 Compare September 16, 2022 00:54

oli-obk removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 16, 2022

bors merged commit af3c8b2 into rust-lang:master Feb 16, 2023

rustbot added this to the 1.69.0 milestone Feb 16, 2023

cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 16, 2023

nnethercote deleted the rm-save-analysis branch February 16, 2023 21:12

Dr-Emann mentioned this pull request Jul 27, 2023

Save-Analysis has been removed from rust est31/warnalyzer#10

Closed

wfraser mentioned this pull request Aug 24, 2023

RLS save-analysis is gone, need some other way to inspect crates wfraser/rsbrowse#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove save-analysis. #101841

Remove save-analysis. #101841

nnethercote commented Sep 15, 2022 •

edited by Mark-Simulacrum

rustbot commented Sep 15, 2022

nnethercote commented Sep 15, 2022

nnethercote commented Sep 15, 2022

rust-timer commented Sep 15, 2022

bors commented Sep 15, 2022

bors commented Sep 15, 2022

rust-timer commented Sep 15, 2022

rust-timer commented Sep 15, 2022

est31 commented Sep 15, 2022

lqd commented Sep 15, 2022 •

edited

nnethercote commented Sep 15, 2022

nnethercote commented Sep 16, 2022

oli-obk commented Sep 16, 2022

rfcbot commented Sep 16, 2022 •

edited by estebank

rust-timer commented Feb 16, 2023

Remove save-analysis. #101841

Remove save-analysis. #101841

Conversation

nnethercote commented Sep 15, 2022 • edited by Mark-Simulacrum

rustbot commented Sep 15, 2022

nnethercote commented Sep 15, 2022

nnethercote commented Sep 15, 2022

rust-timer commented Sep 15, 2022

bors commented Sep 15, 2022

bors commented Sep 15, 2022

rust-timer commented Sep 15, 2022

rust-timer commented Sep 15, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

est31 commented Sep 15, 2022

lqd commented Sep 15, 2022 • edited

nnethercote commented Sep 15, 2022

nnethercote commented Sep 16, 2022

oli-obk commented Sep 16, 2022

rfcbot commented Sep 16, 2022 • edited by estebank

rust-timer commented Feb 16, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Sep 15, 2022 •

edited by Mark-Simulacrum

lqd commented Sep 15, 2022 •

edited

rfcbot commented Sep 16, 2022 •

edited by estebank