Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test validating successful fix #103733

Closed
wants to merge 1 commit into from
Closed

Add test validating successful fix #103733

wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

#103279 didn't backport cleanly so I wanted to make sure it included a test, this is that test (also included in the to-be-opened backport, but no reason to keep it solely on beta).

cc #103243

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2022
@Mark-Simulacrum
Copy link
Member Author

r? @compiler-errors

@compiler-errors
Copy link
Member

The test is similar to the further-minimized src/test/ui/consts/unnormalized-param-env.rs that was included in the PR, but there's no harm in including this version too I guess.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 29, 2022

📌 Commit 38968da has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@Mark-Simulacrum
Copy link
Member Author

Oh, I completely ... missed that there was a test in the PR. Not sure how that happened. Let's avoid the extra test then, no need to bloat our test suite.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the add-test-for-issue branch October 29, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mark-Simulacrum @rustbot @compiler-errors @bors