Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 8 pull requests #103745

Merged
merged 16 commits into from Oct 30, 2022
Merged

Rollup of 8 pull requests #103745

merged 16 commits into from Oct 30, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jyn514 and others added 16 commits September 14, 2022 18:50
@jyn514
Make core::mem::copy const
b5d5682
Add tests for autoderef on block tail
3e90419
@notriddle
rustdoc: add test case for masked blanket impl
8de7a4f
@tshepang
use consistent terminology
a36a37e 
I did not see other traits using the "interface" word
@TaKO8Ki
avoid unnecessary &str to String conversions
a3a3f4d
@GuillaumeGomez
Fix z-indexes of code example feature and cleanup its CSS
4fac361
@notriddle
rustdoc: use CSS margin/padding shorthand when all are being set
d490ff4
@Mark-Simulacrum @joshtriplett
@CryZe @memoryruins @pthariensflame
1.65.0 release notes
3f56a82 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Christopher Serr <christopher.serr@gmail.com>
Co-authored-by: memoryruins <michael@memoryruins.com>
Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>
@matthiaskrgr
Rollup merge of rust-lang#100006 - jyn514:update-copy, r=dtolnay
22e320b 
Make `core::mem::copy` const

cc rust-lang#98262, rust-lang/libs-team#78
@matthiaskrgr
Rollup merge of rust-lang#102659 - Mark-Simulacrum:relnotes, r=Mark-S…
23ff93c 
…imulacrum

1.65.0 release notes

r? `@cuviper` (since you're writing the blog)
@matthiaskrgr
Rollup merge of rust-lang#103124 - ldm0:nohard_tests, r=Mark-Simulacrum
3b12086 
Add tests for autoderef on block tail

ref: rust-lang#83850 (comment)
@matthiaskrgr
Rollup merge of rust-lang#103253 - notriddle:notriddle/test-case-mask…
6460d3b 
…ed-blanket-impl, r=Mark-Simulacrum

rustdoc: add test case for masked blanket impl
@matthiaskrgr
Rollup merge of rust-lang#103715 - tshepang:consistency, r=Dylan-DPC
e4821d7 
use consistent terminology

I did not see other traits using the "interface" word
@matthiaskrgr
Rollup merge of rust-lang#103722 - GuillaumeGomez:cleanup-code-exampl…
6e20768 
…e-css, r=notriddle

Fix z-indexes of code example feature and cleanup its CSS

When reviewing rust-lang#103650, I realized that the `z-index`es of this feature were completely broken:

![Screenshot from 2022-10-28 10-55-27](https://user-images.githubusercontent.com/3050060/198826360-0c5cbe5a-ea8e-452a-9504-38d3da3615e6.png)

This PR fixes it by reducing the value of value under the one used for `.popover` (it could be completely removed but then it wouldn't be displayed as nicely).

There was also a lot of duplicated CSS so I merged the rules.

r? `@notriddle`
@matthiaskrgr
Rollup merge of rust-lang#103726 - TaKO8Ki:avoid-&str-to-string-conve…
2bff9e2 
…rsions, r=compiler-errors

Avoid unnecessary `&str` to `String` conversions
@matthiaskrgr
Rollup merge of rust-lang#103737 - notriddle:notriddle/margin, r=Guil…
9c5e61c 
…laumeGomez

rustdoc: use CSS margin/padding shorthand when all are being set
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 29, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented Oct 29, 2022

📌 Commit 9c5e61c has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@bors
Copy link
Contributor

bors commented Oct 30, 2022

⌛ Testing commit 9c5e61c with merge 4827cee...

@bors
Copy link
Contributor

bors commented Oct 30, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4827cee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2022
@bors bors merged commit 4827cee into rust-lang:master Oct 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Oct 30, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103737 04709545d70f92560e9a20281ca6cba3a7cc53b9
#103726 f3522610f72f589e40a160ef65dd934aad0cea9e
#103722 f719819345d85224c44e30e63faf3e9013f97851
#103715 ec244bdcd97cc45167e380ceaaa5311d109d6bc6
#103253 6ea0563b3c2f85b5da51d49f45c0d8a6c7b6aa72
#103124 58674bcbb5488be95613483242ca2de94808fa9c
#102659 3a43c762d30732575f35ed96182bb44b286310a0
#100006 4f7a480616269a08e568f0b5da32b2ba62a0ea3e

previous master: 15ee24a2fa

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Oct 30, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4827cee): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.3% [-1.4%, -1.2%] 2
Improvements ✅
(secondary)		 -2.0% [-4.0%, -0.5%] 12
All ❌✅ (primary) -1.3% [-1.4%, -1.2%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.6%, -2.1%] 3
All ❌✅ (primary) - - 0

@matthiaskrgr matthiaskrgr deleted the rollup-hipjva8 branch December 22, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@matthiaskrgr @bors @rust-timer @rustbot @jyn514 @notriddle @tshepang @TaKO8Ki @GuillaumeGomez @Mark-Simulacrum