Suggest .clone() or ref binding on E0382
#103908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
commented
Nov 3, 2022
src/test/ui/borrowck/bindings-after-at-or-patterns-slice-patterns-box-patterns.stderr
Outdated
Show resolved
Hide resolved
compiler-errors
added
S-waiting-on-author
chenyukang
reviewed
Nov 3, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
consider-cloning
branch
from
fa68a52
to
d2940e1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
estebank
force-pushed
the
consider-cloning
branch
from
f345620
to
99faafe
Compare
estebank
commented
Nov 3, 2022
src/test/ui/unboxed-closures/unboxed-closures-infer-fnonce-move-call-twice.stderr
Outdated
Show resolved
Hide resolved
estebank
added
S-waiting-on-review
| | | ||
| help: consider cloning the value if the performance cost is acceptable | ||
| | | ||
| LL | let mut t: T = (0, Box::new(0)); drop(t.clone()); |
There was a problem hiding this comment.
Hm, I wonder how easy it is easy to suppress this 🤔
compiler-errors
removed
the
S-waiting-on-review
Do not suggest `.clone()` as we already suggest borrowing the iterated value.
estebank
force-pushed
the
consider-cloning
branch
from
12e3ce4
to
e37926f
Compare
|
@bors r=compiler-errors |
|
📌 Commit e37926f0b62f4174c9aee897d049ff4b30b3941a has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
estebank
force-pushed
the
consider-cloning
branch
from
e37926f
to
78b8d12
Compare
|
@bors r=compiler-errors |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103908 (Suggest `.clone()` or `ref binding` on E0382) - rust-lang#104517 (Throw error on failure in loading llvm-plugin) - rust-lang#104594 (Properly handle `Pin<&mut dyn* Trait>` receiver in codegen) - rust-lang#104742 (Make `deref_into_dyn_supertrait` lint the impl and not the usage) - rust-lang#104753 (Pass `InferCtxt` to `DropRangeVisitor` so we can resolve vars) - rust-lang#104771 (Add regression test for issue rust-lang#99938) - rust-lang#104772 (Small accessibility improvements) - rust-lang#104775 (Use ObligationCtxt::normalize) - rust-lang#104778 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.