Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a GAT for Residual #104128

Closed
wants to merge 1 commit into from
Closed

Use a GAT for Residual #104128

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2022

See discussion in #91285 (comment) for info.

Tracking issue: #91285

These unstable APIs were updated:
array_try_from_fn: #89379
array_try_map: #79711
iterator_try_collect: #94047
iterator_try_reduce: #87053
try_find: #63178

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 7, 2022
@ghost
Copy link
Author

ghost commented Nov 7, 2022

@rustbot label -T-libs

@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 7, 2022
@ghost
Copy link
Author

ghost commented Nov 7, 2022

@rustbot label -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022
@ghost ghost marked this pull request as ready for review November 7, 2022 23:01
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ghost ghost marked this pull request as draft November 7, 2022 23:02
@ghost
Copy link
Author

ghost commented Nov 7, 2022

@bors try

@bors
Copy link
Contributor

bors commented Nov 7, 2022

@H4x5: 🔑 Insufficient privileges: not in try users

@ghost ghost marked this pull request as ready for review November 7, 2022 23:37
@ghost
Copy link
Author

ghost commented Nov 7, 2022

r? @scottmcm

@ghost
Copy link
Author

ghost commented Nov 7, 2022

@rustbot label +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2022
@scottmcm
Copy link
Member

scottmcm commented Nov 9, 2022

Thanks for sending a PR! I agree that all the core impls would work great with a GAT here.

I have some concerns about using a GAT here, though. I've put some comments in the tracking issue (#91285 (comment)) so they won't get lost when this PR either merges or gets closed; let's discuss this more over there?

@scottmcm scottmcm added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Nov 9, 2022
@scottmcm
Copy link
Member

scottmcm commented Nov 9, 2022

Given your comment over in #91285 (comment), I'm going to close this for now. We can always reopen it in future should the design discussions end up deciding that that GAT version is better!

@scottmcm scottmcm closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants