Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few known-bug tests #104181

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Add a few known-bug tests #104181

merged 1 commit into from
Nov 14, 2022

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Nov 9, 2022 •
edited by workingjubilee

The labels of these tests should be changed from S-bug-has-mcve to S-bug-has-test once this is merged.

cc:

I couldn't reproduce the failures in #101962 and #100772 (so either these have started passing, or I didn't repro properly), so leaving those out for now.

#102065 was a bit more complicated, since it uses rustc_private and I didn't want to mess with that.

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2022
@jackh726 jackh726 force-pushed the known-bug-tests branch 2 times, most recently from 6d3a6da to df43e4c Compare November 9, 2022 03:29
@matthiaskrgr
Copy link
Member

(so either these have started passing, or I didn't repro properly)

I can still reproduce both of the ICEs with latest nightly 🤔

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member Author

jackh726 commented Nov 9, 2022

(so either these have started passing, or I didn't repro properly)

I can still reproduce both of the ICEs with latest nightly 🤔

Likely I just didn't make the reproductions correctly.

@jackh726 jackh726 force-pushed the known-bug-tests branch 2 times, most recently from 500812d to b1a9fbd Compare November 10, 2022 02:39
@BGR360
Copy link
Contributor

BGR360 commented Nov 10, 2022 •
edited

Interesting, I didn't know we put tests for known bugs. Does // known-bug: #XXXXX do anything special? I'm wondering how folks who fix bugs are expected to search for / find known-bug tests.

@jackh726
Copy link
Member Author

The known-bug attribute disables the need for error annotations. They aren't useful so much for searching for tests to fix, but rather to document known issues and help catch fixes or changes from unrelated things.

Mark-Simulacrum
Mark-Simulacrum reviewed Nov 13, 2022
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with either revisions removed or an explanation

src/test/incremental/issue-101518.rs Outdated
@@ -0,0 +1,31 @@
// revisions: cfail1 cfail2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like these aren't actually used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental test seem to require revisions. But I suppose we only need one.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2022
@jackh726
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Nov 13, 2022

📌 Commit 1bf8f87 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2022
@jackh726
Copy link
Member Author

@bors rollup

@Manishearth Manishearth mentioned this pull request Nov 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2022
@bors
Auto merge of rust-lang#104387 - Manishearth:rollup-9e551p5, r=Manish…
96ddd32 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103709 (ci: Upgrade dist-x86_64-netbsd to NetBSD 9.0)
 - rust-lang#103744 (Upgrade cc for working is_flag_supported on cross-compiles)
 - rust-lang#104105 (llvm: dwo only emitted when object code emitted)
 - rust-lang#104158 (Return .efi extension for EFI executable)
 - rust-lang#104181 (Add a few known-bug tests)
 - rust-lang#104266 (Regression test for coercion of mut-ref to dyn-star)
 - rust-lang#104300 (Document `Path::parent` behavior around relative paths)
 - rust-lang#104304 (Enable profiler in dist-s390x-linux)
 - rust-lang#104362 (Add `delay_span_bug` to `AttrWrapper::take_for_recovery`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d76058d into rust-lang:master Nov 14, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 14, 2022
@jackh726 jackh726 deleted the known-bug-tests branch November 14, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jackh726 @rustbot @matthiaskrgr @rust-log-analyzer @BGR360 @bors @Mark-Simulacrum