Change multiline span ASCII art visual order #104795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
commented
Nov 25, 2022
Comment on lines
998
to
+1013
| 3 | X0 Y0 Z0 | ||
| | ______^ | ||
| 4 | | 1 | ||
| 5 | | 2 | ||
| 6 | | 3 | ||
| 7 | | X1 Y1 Z1 | ||
| | |_________- | ||
| | _______^ | ||
| 4 | | 1 | ||
| 5 | | 2 | ||
| 6 | | 3 | ||
| 7 | | X1 Y1 Z1 | ||
| | | _________- | ||
| 8 | || 4 | ||
| 9 | || 5 | ||
| 10 | || 6 | ||
| 11 | || X2 Y2 Z2 | ||
| | ||__________- `Z` is a good letter too | ||
| ... | | ||
| 15 | | 10 | ||
| 16 | | X3 Y3 Z3 | ||
| | |_______^ `Y` is a good letter | ||
| ... | | ||
| 15 | | 10 | ||
| 16 | | X3 Y3 Z3 | ||
| | |________^ `Y` is a good letter |
There was a problem hiding this comment.
This is the main case I wanted to address.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 27, 2022
Change multiline span ASCII art visual order Tweak the ASCII art for nested multiline spans so that we minimize line overlaps. Partially addresses rust-lang#61017.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 27, 2022
Change multiline span ASCII art visual order Tweak the ASCII art for nested multiline spans so that we minimize line overlaps. Partially addresses rust-lang#61017.
|
@bors r- clippy tests need to be blessed |
bors
added
S-waiting-on-author
estebank
force-pushed
the
multiline-spans
branch
from
d84cff7
to
136ffa2
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r=TaKO8Ki |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#104360 (Stabilize native library modifier `verbatim`) - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff) - rust-lang#104795 (Change multiline span ASCII art visual order) - rust-lang#104890 (small method code cleanup) - rust-lang#104907 (Remove `SelectionContext::infcx()` in favor of field access) - rust-lang#104927 (Simplify some binder shifting logic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the ASCII art for nested multiline spans so that we minimize line overlaps.
Partially addresses #61017.