rustpkg: Handle requested versions in extern mod directives properly
#10494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let p_id = PkgId::new("foo"); | ||
| let dep_id = git_repo_pkg(); | ||
| let workspace = create_local_package(&p_id); | ||
| let workspace = workspace.unwrap(); |
There was a problem hiding this comment.
Shouldn't this be path to allow for cleanup?
There was a problem hiding this comment.
Oops, good call (I was debugging and forgot to include a note to myself to remove it).
|
Closing due to a lack of activity, but as always, feel free to reopen! |
|
I think this might be at least partially addressed by #10593, since that behavior was needed to make some of the crate linking tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton Closes #8711