Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unsafe through inline const #105147

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Allow unsafe through inline const #105147

merged 7 commits into from
Dec 14, 2022

Commits on Dec 13, 2022

  1. Allow unsafe through inline const 

    This is handled similar to closures
    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9342d1e View commit details
    Browse the repository at this point in the history

  2. Allow unsafe through inline const for THIR unsafety checker 

    The closure handling code is changed slightly to avoid allocation
when THIR building failed.
    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    aa5af2a View commit details
    Browse the repository at this point in the history

  3. Add tests

    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f03c2ae View commit details
    Browse the repository at this point in the history

  4. Ensure valid local_data is set for custom mir building 

    MIR unsafety checking requires this to be valid
    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    adf1717 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary recursive call to parent unsafeck 

    All bodies are unsafe checked anyway. Current MIR unsafeck also just
returns for closures.
    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5c58a1b View commit details
    Browse the repository at this point in the history

  6. Add tests (currently broken) for unsafe + inline const pat

    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    d2830cb View commit details
    Browse the repository at this point in the history

  7. Extract shared logic into a new function

    @nbdd0121
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    d6dc912 View commit details
    Browse the repository at this point in the history