Fix for Rustpkg Opt Settings #10526
Merged
Fix for Rustpkg Opt Settings #10526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this as well? It seems like a fairly important thing that we don't want to regress on. The easiest test would probably be to check that an optimized output is smaller than a non-optimized output. |
|
I'm going to just |
bors
added a commit
that referenced
this pull request
Nov 18, 2013
This commit fixes issue #10468. It propagate optimization level from PkgSrc to compile_crate as a rustc::driver::session::OptLevel enum. The 'opt' argument to compile_crate was previously hardcoded as boolean false, such that calls to session::options would always result in the session::No flag being used.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2023
Really dogfood clippy The dogfood success condition was inverted in `tests/dogfood.rs`: ```rust assert!(!failed_packages.is_empty(), …); ``` while instead the `failed_packages` collection must be empty: ```rust assert!(failed_packages.is_empty(), …); ``` And indeed, several clippy lint source files were not clean and had to be fixed in the process. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #10468.
It propagate optimization level from PkgSrc to compile_crate as a rustc::driver::session::OptLevel enum.
The 'opt' argument to compile_crate was previously hardcoded as boolean false, such that calls to session::options would always result in the session::No flag being used.